From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [Linux v4.10.0-rc1] call-traces after suspend-resume (pm? i915? cpu/hotplug?) Date: Thu, 29 Dec 2016 13:58:49 +0200 Message-ID: <8737h7eykm.fsf@gaia.fi.intel.com> References: <20161227211329.GA8195@amd> <87r34sjw29.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sedat.dilek@gmail.com, "Rafael J. Wysocki" Cc: the arch/x86 maintainers , Linux PM , Jani Nikula , Daniel Vetter , intel-gfx , "Rafael J. Wysocki" , LKML , Pavel Machek , Thomas Gleixner List-Id: linux-pm@vger.kernel.org U2VkYXQgRGlsZWsgPHNlZGF0LmRpbGVrQGdtYWlsLmNvbT4gd3JpdGVzOgoKPiBPbiBXZWQsIERl YyAyOCwgMjAxNiBhdCAxMTozMiBQTSwgUmFmYWVsIEouIFd5c29ja2kgPHJhZmFlbEBrZXJuZWwu b3JnPiB3cm90ZToKPj4gT24gV2VkLCBEZWMgMjgsIDIwMTYgYXQgMTE6MDAgQU0sIFNlZGF0IERp bGVrIDxzZWRhdC5kaWxla0BnbWFpbC5jb20+IHdyb3RlOgo+Pj4gT24gV2VkLCBEZWMgMjgsIDIw MTYgYXQgOToyOSBBTSwgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4gd3JvdGU6 Cj4+Pj4gT24gV2VkLCAyOCBEZWMgMjAxNiwgU2VkYXQgRGlsZWsgPHNlZGF0LmRpbGVrQGdtYWls LmNvbT4gd3JvdGU6Cj4+Pj4+IE9uIFR1ZSwgRGVjIDI3LCAyMDE2IGF0IDEwOjEzIFBNLCBQYXZl bCBNYWNoZWsgPHBhdmVsQHVjdy5jej4gd3JvdGU6Cj4+Pj4+PiBIaSEKPj4+Pj4+Cj4+Pj4+Pj4g WyBBZGQgc29tZSBwbSB8IGk5MTUgfCB4ODYgZm9sa3MgXQo+Pj4+Pj4+Cj4+Pj4+Pj4gSGksCj4+ Pj4+Pj4KPj4+Pj4+PiBJIGhhdmUgYnVpbHQgTGludXggdjQuMTAtcmMxIHRvZGF5IG9uIG15IFVi dW50dS9wcmVjaXNlIEFNRDY0IHN5c3RlbQo+Pj4+Pj4+IGFuZCBJIHNlZSBzb21lIGNhbGwtdHJh Y2VzLgo+Pj4+Pj4+IEl0IGlzIHJlcHJvZHVjaWJsZSBvbiBzdXNwZW5kIGFuZCByZXN1bWUuCj4+ Pj4+Pj4KPj4+Pj4+PiBJIGNhbm5vdCBzYXkgd2hpY2ggYXJlYSB0b3VjaGVzIHRoZSBwcm9ibGVt IG9yIGlmIHRoZXNlIGFyZSBzZXZlcmFsCj4+Pj4+Pj4gaW5kZXBlbmRlbnQgcHJvYmxlbXMuCj4+ Pj4+Pj4KPj4+Pj4+PiBGb3IgYSBmdWxsIGRtZXNnLWxvZyBzZWUgYXR0YWNobWVudHMgKG15IGxp bnV4LWNvbmZpZyBpcyBhdHRhY2hlZCwgdG9vKS4KPj4+Pj4+Pgo+Pj4+Pj4+IEhlcmUgc29tZSBo dW5rcy4uLgo+Pj4+Pj4+Cj4+Pj4+Pj4gWyAgIDI5LjAwMzYwMV0gQlVHOiBzbGVlcGluZyBmdW5j dGlvbiBjYWxsZWQgZnJvbSBpbnZhbGlkIGNvbnRleHQgYXQKPj4+Pj4+PiBkcml2ZXJzL2Jhc2Uv cG93ZXIvcnVudGltZS5jOjEwMzIKPj4+Pj4+PiBbICAgMjkuMDAzNjA4XSBpbl9hdG9taWMoKTog MSwgaXJxc19kaXNhYmxlZCgpOiAwLCBwaWQ6IDE0NjksIG5hbWU6IFhvcmcKPj4+Pj4+PiBbICAg MjkuMDAzNjEwXSAxIGxvY2sgaGVsZCBieSBYb3JnLzE0Njk6Cj4+Pj4+Pj4gWyAgIDI5LjAwMzYx MV0gICMwOiAgKCZkZXYtPnN0cnVjdF9tdXRleCl7Ky4rLisufSwgYXQ6Cj4+Pj4+Pj4gWzxmZmZm ZmZmZmEwNjIzYzEzPl0gaTkxNV9tdXRleF9sb2NrX2ludGVycnVwdGlibGUrMHg0My8weDE0MCBb aTkxNV0KPj4+Pj4+PiBbICAgMjkuMDAzNjUzXSBDUFU6IDAgUElEOiAxNDY5IENvbW06IFhvcmcg Tm90IHRhaW50ZWQKPj4+Pj4+PiA0LjEwLjAtcmMxLTEtaW5pemEtc21hbGwgIzEKPj4+Pj4+PiBb ICAgMjkuMDAzNjU1XSBIYXJkd2FyZSBuYW1lOiBTQU1TVU5HIEVMRUNUUk9OSUNTIENPLiwgTFRE Lgo+Pj4+Pj4+IDUzMFUzQkkvNTMwVTRCSS81MzBVNEJILzUzMFUzQkkvNTMwVTRCSS81MzBVNEJI LCBCSU9TIDEzWEsgMDMvMjgvMjAxMwo+Pj4+Pj4+IFsgICAyOS4wMDM2NTZdIENhbGwgVHJhY2U6 Cj4+Pj4+Pgo+Pj4+Pj4gSnVzdCBhIG5vdGUsIGF0IGxlYXN0IDIgbWFjaGluZXMgaGVyZSByZWZ1 c2UgdG8gcmVzdW1lIHdpdGgKPj4+Pj4+IHY0LjEwLXJjMS4gT25lIGhhcyBpbnRlbCBncmFwaGlj cywgb25lIGhhcyBBTUQuIEl0IG1heSBvciBtYXkgbm90IGhhdmUKPj4+Pj4+IGNvbW1vbiBjYXVz ZS4uLgo+Pj4+Pj4KPj4+Pj4KPj4+Pj4gWyBDb3JyZWN0IGxpbnV4LXBtIE1MIGFuZCBhZGQgTWlr YSAmIEphbmkgXQo+Pj4+Pgo+Pj4+PiBUaGFua3MgZm9yIHRoZSBmZWVkYmFjay4KPj4+Pj4KPj4+ Pj4gVGhlcmUgYXJlIHNvbWUgY3B1L2hvdHBsdWcgZml4ZXMgcG9zdC12NC4xMC1yYzEuCj4+Pj4+ IEdpdmUgdGhhdCBhIHRyeS4KPj4+Pj4KPj4+Pj4gWWVzdGVyZGF5LCBhZnRlciBhbnN3ZXJzIGZy b20gZHJtLWludGVsIGZvbGtzIEkgaGF2ZSBzZWVuIHRoYXQgYQo+Pj4+PiBjcHUvaG90cGx1ZyBj b21taXQgWzFdIHdhcyByZXZlcnRlZCBpbgo+Pj4+PiBkcm0taW50ZWwuZ2l0I2RybS1pbnRlbC1u aWdodGx5Lgo+Pj4+PiBJIGhhdmVuJ3QgdHJpZWQgdGhhdC4KPj4+Pj4KPj4+Pj4gSXQncyBnb29k IHdoZW4gVGhvbWFzIGtub3dzIG9mIHRoaXMgYW5kIGdldHMgaW4gY29udGFjdCB3aXRoIGRybS1p bnRlbCBmb2xrcy4KPj4+Pj4KPj4+Pj4gUmVnYXJkcywKPj4+Pj4gLSBTZWRhdCAtCj4+Pj4+Cj4+ Pj4+IFsxXSBodHRwczovL2NnaXQuZnJlZWRlc2t0b3Aub3JnL2RybS1pbnRlbC9jb21taXQvP2g9 ZHJtLWludGVsLW5pZ2h0bHkmaWQ9ZTU1OGYxNzhmNTM5MDE4NWI3MzI0ZmY0YjgxNmI1MmM2YWUz YTkyOAo+Pj4+PiBbMl0gaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9kcm0taW50ZWwvbG9n Lz9oPWRybS1pbnRlbC1uaWdodGx5Cj4+Pj4+Cj4+Pj4+IFAuUy46IFJldmVydCAiY3B1L2hvdHBs dWc6IFByZXZlbnQgb3ZlcndyaXRpbmcgb2YgY2FsbGJhY2tzIgo+Pj4+Pgo+Pj4+PiBUaGlzIHJl dmVydHMgY29tbWl0IGRjMjgwZDkzNjIzOTI3NTcwZGEyNzllOTkzOTM4NzlkYmJhYjM5ZTcKPj4+ Pj4gQXV0aG9yOiBUaG9tYXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4KPj4+Pj4gRGF0 ZTogV2VkIERlYyAyMSAyMDoxOTo0OSAyMDE2ICswMTAwCj4+Pj4+IGNwdS9ob3RwbHVnOiBQcmV2 ZW50IG92ZXJ3cml0aW5nIG9mIGNhbGxiYWNrcwo+Pj4+Pgo+Pj4+PiBJdCBzdGFydGVkIGhhbmdp bmcgYWxsIG1hY2hpbmVzIGluIENJIHMzIHRlc3Q6Cj4+Pj4+IGh0dHBzOi8vaW50ZWwtZ2Z4LWNp LjAxLm9yZy9DSS9pZ3RAZ2VtX2V4ZWNfc3VzcGVuZEBiYXNpYy1zMy5odG1sCj4+Pj4+Cj4+Pj4+ IEJpc2VjdGVkLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNv bT4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNv bT4KPj4+Pgo+Pj4+IFRob21hcyAtCj4+Pj4KPj4+PiBJbmRlZWQsIGJhc2ljYWxseSBhbGwgb2Yg dGhlIGJveGVzIGluIHRoZSBpbnRlbC1nZnggQ0kgaGFuZyBhdCB0aGUKPj4+PiBzdXNwZW5kL3Jl c3VtZSB0ZXN0IHdpdGggZGMyODBkOTM2MjM5ICgiY3B1L2hvdHBsdWc6IFByZXZlbnQgb3Zlcndy aXRpbmcKPj4+PiBvZiBjYWxsYmFja3MiKSwgYW5kIGFmdGVyIHRoZSByZXZlcnQgaW4gdGhlIHRy ZWUgdGhhdCBmZWVkcyB0byB0aGUgQ0ksCj4+Pj4gd2UncmUgYmFjayBvbiB0cmFjay4KPj4+Pgo+ Pj4+IEkgZm91bmQgWzFdLCB3YXMgaG9waW5nIHRvIGdldCBmZWVkYmFjayBmcm9tIE1pa2Egd2hl dGhlciB0aGF0IGhlbHBzCj4+Pj4gYmVmb3JlIHJlcG9ydGluZy4gQ2hyaXMgYWxzbyBzdWdnZXN0 ZWQgWzJdIGFzIGEgcXVpY2sgZml4IGJ1dCBJIGRvbid0Cj4+Pj4ga25vdyBpZiBhbnlvbmUgdHJp ZWQgdGhhdC4KPj4+Pgo+Pj4KPj4+IEhpIEphbmksCj4+Pgo+Pj4gSSBrbm93IHlvdSB3ZXJlIG5v dCBDQ2VkIGluIHRoZSBvcmlnaW5hbCB0aHJlYWQsIHBsZWFzZSBzZWUgWzVdLgo+Pj4KPj4+IFRo ZSBwYXRjaHNldCBmcm9tIFRob21hcyB5b3UgbWVudGlvbiBbMV0gZG9lcyBmaXggb25lIG9mIHRo ZSBwcm9ibGVtcwo+Pj4gSSBoYXZlIHNlZW4sIHBsZWFzZSBzZWUgWzZdLgo+Pj4gV2l0aCB0aGVz ZSBwb3N0LXY0LjEwLXJjMSBwYXRjaGVzIGFwcGxpZWQgYSBjbGVhbiByZXZlcnQgb2YgUmV2ZXJ0 Cj4+PiAiY3B1L2hvdHBsdWc6IFByZXZlbnQgb3ZlcndyaXRpbmcgb2YgY2FsbGJhY2tzIiBpcyBu b3QgcG9zc2libGUuCj4+Pgo+Pj4gQ2FuIHlvdSBnaXZlIGEgY2xlYXIgc3RhdGVtZW50IGlmIHRo ZSBxdWljay1maXggZnJvbSBDaHJpcyBpcyBpbgo+Pj4gY29tYmluYXRpb24gd2l0aCB0aGUgYWJv dmUgcmV2ZXJ0IG9yIG5vdD8KPj4+IEFnYWluc3QgdjQuMTAtcmMxPwo+Pj4gVGVzdGVkIHRvZ2V0 aGVyIHdpdGggdGhlIHBhdGNoc2V0IG9mIFRob21hcz8KPj4KPj4gUGxlYXNlIHRlc3QgdGhlIExp bnVzJyB0cmVlIGZyb20gdG9kYXksIGl0IHNob3VsZCB3b3JrLgo+Pgo+Cj4gTGF0ZXN0IExpbnVz IHRyZWUgKHY0LjEwLXJjMS0xNy1nMmQ3MDZlNzkwZjA1KSBkb2VzIG5vdCBmaXggaXQuCj4KCkxh dGVzdCBMaW51cyB0cmVlIDJkNzA2ZTc5MGYwNTA4ZGZmNGZiNzJlY2E5YjQ4OTJiNzk3NTdmZWIg Zml4ZXMgb3VyIFMzCnByb2JsZW1zLiBJdCBzdXJ2aXZlcyBnZW1fZXhlY19zdXNwZW5kIC0tciBi YXNpYy1TMyBvbiBrYWJ5bGFrZS4KCkl0IGNvbnRhaW5zIHRoZSBmaXggdG8gdGhlIGJpc2VjdGVk IGNvbW1pdDoKCmNvbW1pdCBiOWQ5ZDY5MTFiZDVjMzcwYWQ0YjNhYTU3ZDc1OGMwOTNkMTdhZWQ1 CkF1dGhvcjogVGhvbWFzIEdsZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+CkRhdGU6ICAgTW9u IERlYyAyNiAyMjo1ODoxOSAyMDE2ICswMTAwCgogICAgc21wL2hvdHBsdWc6IFVuZG8gdGdseHMg YnJhaW5mYXJ0CgoKLU1pa2EKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714AbcL2MAA (ORCPT ); Thu, 29 Dec 2016 07:00:00 -0500 Received: from mga05.intel.com ([192.55.52.43]:3603 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752226AbcL2L75 (ORCPT ); Thu, 29 Dec 2016 06:59:57 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,426,1477983600"; d="scan'208";a="803283978" From: Mika Kuoppala To: sedat.dilek@gmail.com, "Rafael J. Wysocki" Cc: Jani Nikula , Pavel Machek , Thomas Gleixner , "Rafael J. Wysocki" , Daniel Vetter , Chris Wilson , intel-gfx , LKML , "the arch\/x86 maintainers" , Linux PM Subject: Re: [Linux v4.10.0-rc1] call-traces after suspend-resume (pm? i915? cpu/hotplug?) In-Reply-To: References: <20161227211329.GA8195@amd> <87r34sjw29.fsf@intel.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 29 Dec 2016 13:58:49 +0200 Message-ID: <8737h7eykm.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sedat Dilek writes: > On Wed, Dec 28, 2016 at 11:32 PM, Rafael J. Wysocki wrote: >> On Wed, Dec 28, 2016 at 11:00 AM, Sedat Dilek wrote: >>> On Wed, Dec 28, 2016 at 9:29 AM, Jani Nikula wrote: >>>> On Wed, 28 Dec 2016, Sedat Dilek wrote: >>>>> On Tue, Dec 27, 2016 at 10:13 PM, Pavel Machek wrote: >>>>>> Hi! >>>>>> >>>>>>> [ Add some pm | i915 | x86 folks ] >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I have built Linux v4.10-rc1 today on my Ubuntu/precise AMD64 system >>>>>>> and I see some call-traces. >>>>>>> It is reproducible on suspend and resume. >>>>>>> >>>>>>> I cannot say which area touches the problem or if these are several >>>>>>> independent problems. >>>>>>> >>>>>>> For a full dmesg-log see attachments (my linux-config is attached, too). >>>>>>> >>>>>>> Here some hunks... >>>>>>> >>>>>>> [ 29.003601] BUG: sleeping function called from invalid context at >>>>>>> drivers/base/power/runtime.c:1032 >>>>>>> [ 29.003608] in_atomic(): 1, irqs_disabled(): 0, pid: 1469, name: Xorg >>>>>>> [ 29.003610] 1 lock held by Xorg/1469: >>>>>>> [ 29.003611] #0: (&dev->struct_mutex){+.+.+.}, at: >>>>>>> [] i915_mutex_lock_interruptible+0x43/0x140 [i915] >>>>>>> [ 29.003653] CPU: 0 PID: 1469 Comm: Xorg Not tainted >>>>>>> 4.10.0-rc1-1-iniza-small #1 >>>>>>> [ 29.003655] Hardware name: SAMSUNG ELECTRONICS CO., LTD. >>>>>>> 530U3BI/530U4BI/530U4BH/530U3BI/530U4BI/530U4BH, BIOS 13XK 03/28/2013 >>>>>>> [ 29.003656] Call Trace: >>>>>> >>>>>> Just a note, at least 2 machines here refuse to resume with >>>>>> v4.10-rc1. One has intel graphics, one has AMD. It may or may not have >>>>>> common cause... >>>>>> >>>>> >>>>> [ Correct linux-pm ML and add Mika & Jani ] >>>>> >>>>> Thanks for the feedback. >>>>> >>>>> There are some cpu/hotplug fixes post-v4.10-rc1. >>>>> Give that a try. >>>>> >>>>> Yesterday, after answers from drm-intel folks I have seen that a >>>>> cpu/hotplug commit [1] was reverted in >>>>> drm-intel.git#drm-intel-nightly. >>>>> I haven't tried that. >>>>> >>>>> It's good when Thomas knows of this and gets in contact with drm-intel folks. >>>>> >>>>> Regards, >>>>> - Sedat - >>>>> >>>>> [1] https://cgit.freedesktop.org/drm-intel/commit/?h=drm-intel-nightly&id=e558f178f5390185b7324ff4b816b52c6ae3a928 >>>>> [2] https://cgit.freedesktop.org/drm-intel/log/?h=drm-intel-nightly >>>>> >>>>> P.S.: Revert "cpu/hotplug: Prevent overwriting of callbacks" >>>>> >>>>> This reverts commit dc280d93623927570da279e99393879dbbab39e7 >>>>> Author: Thomas Gleixner >>>>> Date: Wed Dec 21 20:19:49 2016 +0100 >>>>> cpu/hotplug: Prevent overwriting of callbacks >>>>> >>>>> It started hanging all machines in CI s3 test: >>>>> https://intel-gfx-ci.01.org/CI/igt@gem_exec_suspend@basic-s3.html >>>>> >>>>> Bisected-by: Mika Kuoppala >>>>> Signed-off-by: Jani Nikula >>>> >>>> Thomas - >>>> >>>> Indeed, basically all of the boxes in the intel-gfx CI hang at the >>>> suspend/resume test with dc280d936239 ("cpu/hotplug: Prevent overwriting >>>> of callbacks"), and after the revert in the tree that feeds to the CI, >>>> we're back on track. >>>> >>>> I found [1], was hoping to get feedback from Mika whether that helps >>>> before reporting. Chris also suggested [2] as a quick fix but I don't >>>> know if anyone tried that. >>>> >>> >>> Hi Jani, >>> >>> I know you were not CCed in the original thread, please see [5]. >>> >>> The patchset from Thomas you mention [1] does fix one of the problems >>> I have seen, please see [6]. >>> With these post-v4.10-rc1 patches applied a clean revert of Revert >>> "cpu/hotplug: Prevent overwriting of callbacks" is not possible. >>> >>> Can you give a clear statement if the quick-fix from Chris is in >>> combination with the above revert or not? >>> Against v4.10-rc1? >>> Tested together with the patchset of Thomas? >> >> Please test the Linus' tree from today, it should work. >> > > Latest Linus tree (v4.10-rc1-17-g2d706e790f05) does not fix it. > Latest Linus tree 2d706e790f0508dff4fb72eca9b4892b79757feb fixes our S3 problems. It survives gem_exec_suspend --r basic-S3 on kabylake. It contains the fix to the bisected commit: commit b9d9d6911bd5c370ad4b3aa57d758c093d17aed5 Author: Thomas Gleixner Date: Mon Dec 26 22:58:19 2016 +0100 smp/hotplug: Undo tglxs brainfart -Mika