From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test Date: Fri, 11 Nov 2016 10:00:07 +0000 Message-ID: <8737iy8hg8.fsf@linaro.org> References: <1478798481-25030-1-git-send-email-drjones@redhat.com> <1478798481-25030-11-git-send-email-drjones@redhat.com> <874m3f8621.fsf@linaro.org> <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4C933404BA for ; Fri, 11 Nov 2016 04:59:47 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J0vG28gPA-uk for ; Fri, 11 Nov 2016 04:59:46 -0500 (EST) Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D8867404DE for ; Fri, 11 Nov 2016 04:59:45 -0500 (EST) Received: by mail-wm0-f42.google.com with SMTP id f82so82372205wmf.1 for ; Fri, 11 Nov 2016 02:00:10 -0800 (PST) In-reply-to: <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Andre Przywara Cc: kvm@vger.kernel.org, marc.zyngier@arm.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com, kvmarm@lists.cs.columbia.edu List-Id: kvmarm@lists.cs.columbia.edu CkFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPiB3cml0ZXM6Cgo+IEhpLAo+ Cj4gT24gMTAvMTEvMTYgMTk6NTMsIEFsZXggQmVubsOpZSB3cm90ZToKPgo+IC4uLi4KPj4gU28g SSB3YXMgcmUtYmFzaW5nIG15IGt2bS11bml0LXRlc3RzIGFnYWluc3QgeW91ciBHSUMgcmV3b3Jr IGFuZCBmb3VuZAo+PiBteXNlbGYgY29weSBhbmQgcGFzdGluZyBhIGJ1bmNoIG9mIHRoaXMgaW50 byBteSB0ZXN0cyB0aGF0IGZpcmUgSVJRcy4KPgo+IFNvIEkgdGFrZSBpdCB5b3UgYXJlIHdvcmtp bmcgb24gKG9yIGFscmVhZHkgaGF2ZSkgY29kZSB0byB0ZXN0IFNQSXMsCj4gcHJvYmFibHkgdmlh IEdJQ0RfSVNQRU5EUj8KPiBKdXN0IGFza2luZyBiZWNhdXNlIEkgd2FzIHRoaW5raW5nIGFib3V0 IGdvaW5nIHRoZXJlIGFuZCB0aHVzIGNvdWxkIHNhdmUKPiBteSB0aW1lIGlmIHlvdSBhcmUgb24g aXQgYWxyZWFkeS4uLgoKSW4gbXkgY2FzZSBJIHdhbnRlZCB0byB0cmlnZ2VyIFNQSXMgdG8gZXhl cmNpc2UgbXkgVENHIHRlc3RzIGZvciBNVFRDRzoKCiAgaHR0cHM6Ly9naXRodWIuY29tL3N0c3F1 YWQva3ZtLXVuaXQtdGVzdHMvYmxvYi9tdHRjZy9jdXJyZW50LXRlc3RzLXY2L2FybS90Y2ctdGVz dC5jI0wxMTMKCj4+IFRoYXQgbWFrZXMgbWUgdGhpbmsgdGhlIGFic3RyYWN0aW9uIHNob3VsZCBi ZSBpbiB0aGUgbGlicmFyeSBjb2RlIHNvCj4+IG90aGVyIHRlc3RzIGNhbiBmaWRkbGUgd2l0aCBz ZW5kaW5nIElSUXMuCj4KPiAuLi5iZWNhdXNlIEkgd2FzIHdvbmRlcmluZyB0aGUgc2FtZS4KClRv IGFuc3dlciBBbmRyZXcncyBxdWVzdGlvbiBmcm9tIHRoZSBvdGhlciBwb3N0IEkgd291bGQgYmUg aGFwcHkgd2l0aCBhCmNvbW1vbjoKCiAgZ2ljX2VuYWJsZQogIGdpY19zZW5kX3NwaShjcHUsIGly cSkKICBnaWNfaXJxX2FjaygpIHdoaWNoIHJldHVybnMgdGhlIGlhci4KCgo+Cj4gQ2hlZXJzLAo+ IEFuZHJlLgoKCi0tCkFsZXggQmVubsOpZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1 bWJpYS5lZHUKaHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9r dm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id c188sm10116440wmd.22.2016.11.11.02.00.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Nov 2016 02:00:08 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id D43DC3E04F2; Fri, 11 Nov 2016 10:00:07 +0000 (GMT) References: <1478798481-25030-1-git-send-email-drjones@redhat.com> <1478798481-25030-11-git-send-email-drjones@redhat.com> <874m3f8621.fsf@linaro.org> <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> User-agent: mu4e 0.9.17; emacs 25.1.50.16 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Andre Przywara Cc: Andrew Jones , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com, peter.maydell@linaro.org, marc.zyngier@arm.com, eric.auger@redhat.com, christoffer.dall@linaro.org Subject: Re: [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test In-reply-to: <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> Date: Fri, 11 Nov 2016 10:00:07 +0000 Message-ID: <8737iy8hg8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TUID: Db1B85+YZlS6 Andre Przywara writes: > Hi, > > On 10/11/16 19:53, Alex Bennée wrote: > > .... >> So I was re-basing my kvm-unit-tests against your GIC rework and found >> myself copy and pasting a bunch of this into my tests that fire IRQs. > > So I take it you are working on (or already have) code to test SPIs, > probably via GICD_ISPENDR? > Just asking because I was thinking about going there and thus could save > my time if you are on it already... In my case I wanted to trigger SPIs to exercise my TCG tests for MTTCG: https://github.com/stsquad/kvm-unit-tests/blob/mttcg/current-tests-v6/arm/tcg-test.c#L113 >> That makes me think the abstraction should be in the library code so >> other tests can fiddle with sending IRQs. > > ...because I was wondering the same. To answer Andrew's question from the other post I would be happy with a common: gic_enable gic_send_spi(cpu, irq) gic_irq_ack() which returns the iar. > > Cheers, > Andre. -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c58d4-0007T6-60 for qemu-devel@nongnu.org; Fri, 11 Nov 2016 05:00:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c58d1-0001ER-5A for qemu-devel@nongnu.org; Fri, 11 Nov 2016 05:00:14 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:36593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c58d0-0001BZ-Mt for qemu-devel@nongnu.org; Fri, 11 Nov 2016 05:00:11 -0500 Received: by mail-wm0-x22e.google.com with SMTP id g23so89334313wme.1 for ; Fri, 11 Nov 2016 02:00:10 -0800 (PST) References: <1478798481-25030-1-git-send-email-drjones@redhat.com> <1478798481-25030-11-git-send-email-drjones@redhat.com> <874m3f8621.fsf@linaro.org> <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> Date: Fri, 11 Nov 2016 10:00:07 +0000 Message-ID: <8737iy8hg8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: Andrew Jones , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com, peter.maydell@linaro.org, marc.zyngier@arm.com, eric.auger@redhat.com, christoffer.dall@linaro.org Andre Przywara writes: > Hi, > > On 10/11/16 19:53, Alex Bennée wrote: > > .... >> So I was re-basing my kvm-unit-tests against your GIC rework and found >> myself copy and pasting a bunch of this into my tests that fire IRQs. > > So I take it you are working on (or already have) code to test SPIs, > probably via GICD_ISPENDR? > Just asking because I was thinking about going there and thus could save > my time if you are on it already... In my case I wanted to trigger SPIs to exercise my TCG tests for MTTCG: https://github.com/stsquad/kvm-unit-tests/blob/mttcg/current-tests-v6/arm/tcg-test.c#L113 >> That makes me think the abstraction should be in the library code so >> other tests can fiddle with sending IRQs. > > ...because I was wondering the same. To answer Andrew's question from the other post I would be happy with a common: gic_enable gic_send_spi(cpu, irq) gic_irq_ack() which returns the iar. > > Cheers, > Andre. -- Alex Bennée