From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] Revert "drm: Unify handling of blob and object properties" Date: Wed, 07 Sep 2016 14:25:09 +0300 Message-ID: <8737lcx88a.fsf@intel.com> References: <20160829082757.17913-1-daniel.vetter@ffwll.ch> <20160829082757.17913-8-daniel.vetter@ffwll.ch> <8c0d3482-1bb5-6a15-b105-6bda2b31b5dc@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13E076E9CE for ; Wed, 7 Sep 2016 11:25:11 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ying Liu , Maarten Lankhorst Cc: Daniel Vetter , Daniel Stone , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAwNyBTZXAgMjAxNiwgWWluZyBMaXUgPGdudWl5bEBnbWFpbC5jb20+IHdyb3RlOgo+ IE9uIFdlZCwgU2VwIDcsIDIwMTYgYXQgNTo1MiBQTSwgTWFhcnRlbiBMYW5raG9yc3QKPiA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4gVGhpcyByZXZlcnRzIGNv bW1pdCA3Nzk1M2JkMTM2ZDJhNzBiY2EyZGM5M2IzY2NkYTA3YTJiMzcwNzZmLgo+Pgo+PiBUaGlz IGNhdXNlcyBhIGtlcm5lbCBwYW5pYyB3aGVuIHRyeWluZyB0byBhc3NpZ24gYSBibG9iIHRvIGEg cHJvcGVydHksCj4+IGFuZCBoYXMgb2J2aW91c2x5IG5ldmVyIGJlZW4gdGVzdGVkLgo+Pgo+PiBT aWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgo+Cj4gVGVzdGVkLWJ5OiBMaXUgWWluZyA8Z251aXlsQGdtYWlsLmNvbT4KClB1 c2hlZCB0byBkcm0tbWlzYyB3aXRoIERhbmllbCdzIGlyYyBhY2suCgpCUiwKSmFuaS4KCgo+Cj4+ IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jIHwgMjMgKysrKysrKysrKysr KysrKysrLS0tLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0 aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5j IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jCj4+IGluZGV4IDQxMzlhZmJjYzI2Ny4u YTRkODFjZjRmZmEwIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb3BlcnR5 LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9wZXJ0eS5jCj4+IEBAIC04NzAsOCAr ODcwLDIwIEBAIGJvb2wgZHJtX3Byb3BlcnR5X2NoYW5nZV92YWxpZF9nZXQoc3RydWN0IGRybV9w cm9wZXJ0eSAqcHJvcGVydHksCj4+ICAgICAgICAgICAgICAgICBmb3IgKGkgPSAwOyBpIDwgcHJv cGVydHktPm51bV92YWx1ZXM7IGkrKykKPj4gICAgICAgICAgICAgICAgICAgICAgICAgdmFsaWRf bWFzayB8PSAoMVVMTCA8PCBwcm9wZXJ0eS0+dmFsdWVzW2ldKTsKPj4gICAgICAgICAgICAgICAg IHJldHVybiAhKHZhbHVlICYgfnZhbGlkX21hc2spOwo+PiAtICAgICAgIH0gZWxzZSBpZiAoZHJt X3Byb3BlcnR5X3R5cGVfaXMocHJvcGVydHksIERSTV9NT0RFX1BST1BfQkxPQikgfHwKPj4gLSAg ICAgICAgICAgICAgICAgIGRybV9wcm9wZXJ0eV90eXBlX2lzKHByb3BlcnR5LCBEUk1fTU9ERV9Q Uk9QX09CSkVDVCkpIHsKPj4gKyAgICAgICB9IGVsc2UgaWYgKGRybV9wcm9wZXJ0eV90eXBlX2lz KHByb3BlcnR5LCBEUk1fTU9ERV9QUk9QX0JMT0IpKSB7Cj4+ICsgICAgICAgICAgICAgICBzdHJ1 Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmJsb2I7Cj4+ICsKPj4gKyAgICAgICAgICAgICAgIGlmICh2 YWx1ZSA9PSAwKQo+PiArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPj4gKwo+ PiArICAgICAgICAgICAgICAgYmxvYiA9IGRybV9wcm9wZXJ0eV9sb29rdXBfYmxvYihwcm9wZXJ0 eS0+ZGV2LCB2YWx1ZSk7Cj4+ICsgICAgICAgICAgICAgICBpZiAoYmxvYikgewo+PiArICAgICAg ICAgICAgICAgICAgICAgICAqcmVmID0gJmJsb2ItPmJhc2U7Cj4+ICsgICAgICAgICAgICAgICAg ICAgICAgIHJldHVybiB0cnVlOwo+PiArICAgICAgICAgICAgICAgfSBlbHNlIHsKPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+PiArICAgICAgICAgICAgICAgfQo+PiAr ICAgICAgIH0gZWxzZSBpZiAoZHJtX3Byb3BlcnR5X3R5cGVfaXMocHJvcGVydHksIERSTV9NT0RF X1BST1BfT0JKRUNUKSkgewo+PiAgICAgICAgICAgICAgICAgLyogYSB6ZXJvIHZhbHVlIGZvciBh biBvYmplY3QgcHJvcGVydHkgdHJhbnNsYXRlcyB0byBudWxsOiAqLwo+PiAgICAgICAgICAgICAg ICAgaWYgKHZhbHVlID09IDApCj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVl Owo+PiBAQCAtODg4LDEyICs5MDAsMTMgQEAgYm9vbCBkcm1fcHJvcGVydHlfY2hhbmdlX3ZhbGlk X2dldChzdHJ1Y3QgZHJtX3Byb3BlcnR5ICpwcm9wZXJ0eSwKPj4gIH0KPj4KPj4gIHZvaWQgZHJt X3Byb3BlcnR5X2NoYW5nZV92YWxpZF9wdXQoc3RydWN0IGRybV9wcm9wZXJ0eSAqcHJvcGVydHks Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9tb2RlX29i amVjdCAqcmVmKQo+PiArICAgICAgICAgICAgICAgc3RydWN0IGRybV9tb2RlX29iamVjdCAqcmVm KQo+PiAgewo+PiAgICAgICAgIGlmICghcmVmKQo+PiAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ Pgo+PiAtICAgICAgIGlmIChkcm1fcHJvcGVydHlfdHlwZV9pcyhwcm9wZXJ0eSwgRFJNX01PREVf UFJPUF9PQkpFQ1QpIHx8Cj4+IC0gICAgICAgICAgIGRybV9wcm9wZXJ0eV90eXBlX2lzKHByb3Bl cnR5LCBEUk1fTU9ERV9QUk9QX0JMT0IpKQo+PiArICAgICAgIGlmIChkcm1fcHJvcGVydHlfdHlw ZV9pcyhwcm9wZXJ0eSwgRFJNX01PREVfUFJPUF9PQkpFQ1QpKSB7Cj4+ICAgICAgICAgICAgICAg ICBkcm1fbW9kZV9vYmplY3RfdW5yZWZlcmVuY2UocmVmKTsKPj4gKyAgICAgICB9IGVsc2UgaWYg KGRybV9wcm9wZXJ0eV90eXBlX2lzKHByb3BlcnR5LCBEUk1fTU9ERV9QUk9QX0JMT0IpKQo+PiAr ICAgICAgICAgICAgICAgZHJtX3Byb3BlcnR5X3VucmVmZXJlbmNlX2Jsb2Iob2JqX3RvX2Jsb2Io cmVmKSk7Cj4+ICB9Cj4+IC0tCj4+IDIuNy40Cj4+Cj4+Cj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9w ZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=