From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX8MZ-0003tX-4E for qemu-devel@nongnu.org; Tue, 09 Aug 2016 10:50:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX8MT-0002AS-5O for qemu-devel@nongnu.org; Tue, 09 Aug 2016 10:50:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX8MS-0002A3-Va for qemu-devel@nongnu.org; Tue, 09 Aug 2016 10:50:33 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8026F4E323 for ; Tue, 9 Aug 2016 14:50:30 +0000 (UTC) From: Markus Armbruster References: <20160808141439.16908-1-marcandre.lureau@redhat.com> Date: Tue, 09 Aug 2016 16:50:27 +0200 In-Reply-To: <20160808141439.16908-1-marcandre.lureau@redhat.com> (marcandre lureau's message of "Mon, 8 Aug 2016 18:14:24 +0400") Message-ID: <8737mec7yk.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 00/15] qapi: remove the 'middle' mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > Hi, > > Although some QMP commands are still not fully qapi'fied, it is > possible to use more qapi common and generated code by dropping the > 'middle' mode. Overall, I like this series. PATCH 10 looks more complicated than necessary, and PATCH 12 needs to avoid the introspection regression. I still have to double-check qmp_dispatch() does the same as the old monitor code it replaces.