From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Mon, 20 Jun 2016 11:03:44 +0300 Message-ID: <8737o89ti7.fsf@intel.com> References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1466373202.2280.3.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: James Bottomley , Daniel Vetter Cc: intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org CkNjOiBWaWxsZQoKT24gTW9uLCAyMCBKdW4gMjAxNiwgSmFtZXMgQm90dG9tbGV5IDxKYW1lcy5C b3R0b21sZXlASGFuc2VuUGFydG5lcnNoaXAuY29tPiB3cm90ZToKPiBPSywgbXkgY2FuZGlkYXRl IGJhZCBjb21taXQgaXMgdGhpcyBvbmU6Cj4KPiBjb21taXQgYTA1NjI4MTk1YTBkOWYzMTczZGQ5 YWE3NmY0ODJhZWY2OTJlNDZlZQo+IEF1dGhvcjogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiBEYXRlOiAgIE1vbiBBcHIgMTEgMTA6MjM6NTEgMjAxNiAr MDMwMAo+Cj4gICAgIGRybS9pOTE1OiBHZXQgcGFuZWxfdHlwZSBmcm9tIE9wUmVnaW9uIHBhbmVs IGRldGFpbHMKPgo+IEFmdGVyIGJlaW5nIG1vcmUgY2FyZWZ1bCBhYm91dCB3YWl0aW5nIHRvIGlk ZW50aWZ5IGZsaWNrZXIsIHRoaXMgb25lCj4gc2VlbXMgdG8gYmUgdGhlIG9uZSB0aGUgYmlzZWN0 IGZpbmRzLiAgSSdtIG5vdyBydW5uaW5nIHY0LjctcmMzIHdpdGgKPiB0aGlzIG9uZSByZXZlcnRl ZCBhbmQgYW0gY3VycmVudGx5IHNlZWluZyBubyBmbGlja2VyIHByb2JsZW1zLiAgSXQgaXMsCj4g aG93ZXZlciwgZWFybHkgZGF5cyBiZWNhdXNlIHRoZSBmbGlja2VyIGNhbiBoaWRlIGZvciBsb25n IHBlcmlvZHMsIHNvIEkKPiAnbGwgd2FpdCB1bnRpbCBNb25kYXkgZXZlbmluZyBhbmQgYSBmZXcg cmVib290cyBiZWZvcmUgZGVjbGFyaW5nCj4gdmljdG9yeS4KCklmIHRoYXQgdHVybnMgb3V0IHRv IGJlIHRoZSBiYWQgY29tbWl0LCBpdCBkb2Vzbid0IHJlYWxseSBzdXJwcmlzZSBtZSwKYW5kIHRo YXQgaW4gaXRzZWxmIGlzIGRlcHJlc3NpbmcuCgpJdCBtaWdodCBiZSBoZWxwZnVsIGlmIHlvdSBj b3VsZCBhZGQgZHJtLmRlYnVnPTE0IG1vZHVsZSBwYXJhbWV0ZXIsIGFuZApwcm92aWRlIGRtZXNn cyBmcm9tIGJvb3QgYm90aCB3aXRoIGFuZCB3aXRob3V0IHRoZSBhYm92ZSBjb21taXQgKGl0J3MK ZW5vdWdoIHRvIHNlZSBpOTE1IGxvYWQpLiBQbGVhc2UgYWxzbyBwcm92aWRlCi9zeXMva2VybmVs L2RlYnVnL2RyaS8wL2k5MTVfb3ByZWdpb24uCgpCUiwKSmFuaS4KCi0tIApKYW5pIE5pa3VsYSwg SW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252AbcFTIG4 (ORCPT ); Mon, 20 Jun 2016 04:06:56 -0400 Received: from mga02.intel.com ([134.134.136.20]:30699 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbcFTIGu convert rfc822-to-8bit (ORCPT ); Mon, 20 Jun 2016 04:06:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,497,1459839600"; d="scan'208";a="1005710402" From: Jani Nikula To: James Bottomley , Daniel Vetter Cc: intel-gfx , dri-devel , linux-kernel , Rodrigo Vivi , "Syrjala\, Ville" Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window In-Reply-To: <1466373202.2280.3.camel@HansenPartnership.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 20 Jun 2016 11:03:44 +0300 Message-ID: <8737o89ti7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cc: Ville On Mon, 20 Jun 2016, James Bottomley wrote: > OK, my candidate bad commit is this one: > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > Author: Ville Syrjälä > Date: Mon Apr 11 10:23:51 2016 +0300 > > drm/i915: Get panel_type from OpRegion panel details > > After being more careful about waiting to identify flicker, this one > seems to be the one the bisect finds. I'm now running v4.7-rc3 with > this one reverted and am currently seeing no flicker problems. It is, > however, early days because the flicker can hide for long periods, so I > 'll wait until Monday evening and a few reboots before declaring > victory. If that turns out to be the bad commit, it doesn't really surprise me, and that in itself is depressing. It might be helpful if you could add drm.debug=14 module parameter, and provide dmesgs from boot both with and without the above commit (it's enough to see i915 load). Please also provide /sys/kernel/debug/dri/0/i915_opregion. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center