From: "Alex Bennée" <alex.bennee@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, wei@redhat.com,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 5/5] hw/arm/virt: create the 2.7 machine type
Date: Thu, 09 Jun 2016 17:06:43 +0100 [thread overview]
Message-ID: <8737omgxd8.fsf@linaro.org> (raw)
In-Reply-To: <1465410291-2971-6-git-send-email-drjones@redhat.com>
Andrew Jones <drjones@redhat.com> writes:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
I'm confused. These steps have introduced a bunch of boiler plate to set
the default virt machine type so we can introduce 2.7 which is an alias
of the existing 2.6? Wouldn't this be better of waiting until there is a
concrete difference or have I missed something subtle here?
> ---
> hw/arm/virt.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 017c244a46f41..323ffd4689641 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -42,6 +42,7 @@
> #include "sysemu/sysemu.h"
> #include "sysemu/kvm.h"
> #include "hw/boards.h"
> +#include "hw/compat.h"
> #include "hw/loader.h"
> #include "exec/address-spaces.h"
> #include "qemu/bitops.h"
> @@ -1423,7 +1424,7 @@ static void machvirt_machine_init(void)
> }
> type_init(machvirt_machine_init);
>
> -static void virt_2_6_instance_init(Object *obj)
> +static void virt_2_7_instance_init(Object *obj)
> {
> VirtMachineState *vms = VIRT_MACHINE(obj);
>
> @@ -1456,7 +1457,22 @@ static void virt_2_6_instance_init(Object *obj)
> "Valid values are 2, 3 and host", NULL);
> }
>
> +static void virt_machine_2_7_options(MachineClass *mc)
> +{
> +}
> +DEFINE_VIRT_MACHINE_AS_LATEST(2, 7)
> +
> +#define VIRT_COMPAT_2_6 \
> + HW_COMPAT_2_6
> +
> +static void virt_2_6_instance_init(Object *obj)
> +{
> + virt_2_7_instance_init(obj);
> +}
> +
> static void virt_machine_2_6_options(MachineClass *mc)
> {
> + virt_machine_2_7_options(mc);
> + SET_MACHINE_COMPAT(mc, VIRT_COMPAT_2_6);
> }
> -DEFINE_VIRT_MACHINE_AS_LATEST(2, 6)
> +DEFINE_VIRT_MACHINE(2, 6)
--
Alex Bennée
next prev parent reply other threads:[~2016-06-09 16:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 18:24 [Qemu-arm] [PATCH 0/5] create the mach-virt 2.7 machine type Andrew Jones
2016-06-08 18:24 ` [Qemu-devel] " Andrew Jones
2016-06-08 18:24 ` [Qemu-arm] [PATCH 1/5] hw/arm/virt: separate versioned type-init code Andrew Jones
2016-06-08 18:24 ` [Qemu-devel] " Andrew Jones
2016-06-09 18:27 ` Peter Maydell
2016-06-09 18:27 ` Peter Maydell
2016-06-08 18:24 ` [Qemu-arm] [PATCH 2/5] hw/arm/virt: set is_default Andrew Jones
2016-06-08 18:24 ` [Qemu-devel] " Andrew Jones
2016-06-09 18:27 ` Peter Maydell
2016-06-09 18:27 ` Peter Maydell
2016-06-08 18:24 ` [Qemu-arm] [PATCH 3/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE Andrew Jones
2016-06-08 18:24 ` [Qemu-devel] " Andrew Jones
2016-06-09 18:29 ` Peter Maydell
2016-06-09 18:29 ` Peter Maydell
2016-06-08 18:24 ` [Qemu-arm] [PATCH 4/5] hw/arm/virt: introduce DEFINE_VIRT_MACHINE_AS_LATEST Andrew Jones
2016-06-08 18:24 ` [Qemu-devel] " Andrew Jones
2016-06-09 18:30 ` [Qemu-arm] " Peter Maydell
2016-06-09 18:30 ` [Qemu-devel] " Peter Maydell
2016-06-08 18:24 ` [Qemu-devel] [PATCH 5/5] hw/arm/virt: create the 2.7 machine type Andrew Jones
2016-06-08 18:24 ` Andrew Jones
2016-06-09 16:06 ` Alex Bennée [this message]
2016-06-09 16:19 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737omgxd8.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.