From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2] drm/dsi: Implement set tear scanline Date: Tue, 07 Jun 2016 09:54:06 +0300 Message-ID: <8737op7alt.fsf@intel.com> References: <1465234897-21365-1-git-send-email-simhavcs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id B30816E068 for ; Tue, 7 Jun 2016 06:54:09 +0000 (UTC) In-Reply-To: <1465234897-21365-1-git-send-email-simhavcs@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: open list , "open list:DRM DRIVERS" , Vinay Simha BN , Archit Taneja List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCAwNiBKdW4gMjAxNiwgVmluYXkgU2ltaGEgQk4gPHNpbWhhdmNzQGdtYWlsLmNvbT4g d3JvdGU6Cj4gUHJvdmlkZSBhIHNtYWxsIGNvbnZlbmllbmNlIHdyYXBwZXIgdGhhdCB0cmFuc21p dHMKPiBhIHNldF90ZWFyX3NjYW5saW5lIGNvbW1hbmQuCj4KPiBBbHNvIGluY2x1ZGVzIHNtYWxs IGJ1aWxkIGZpeGVzIGZyb20gU3VtaXQgU2Vtd2FsLgo+Cj4gQ2M6IEFyY2hpdCBUYW5lamEgPGFy Y2hpdC50YW5lamFAZ21haWwuY29tPgo+IENjOiBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGlu YXJvLm9yZz4KPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWlsLmNvbT4K PiBDYzogU3VtaXQgU2Vtd2FsIDxzdW1pdC5zZW13YWxAbGluYXJvLm9yZz4KPiBDYzogSmFuaSBO aWt1bGEgPGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaW5h eSBTaW1oYSBCTiA8c2ltaGF2Y3NAZ21haWwuY29tPgo+IC0tCj4gdjE6Cj4gICAqIGhlbHBlciBm dW5jdGlvbiBzdWdnZXN0ZWQgYnkgVGhpZXJyeQo+ICAgICBmb3Igc2V0X3RlYXJfc2NhbmxpbmUK PiB2MjoKPiAgICogb25lIHNjYW5saW5lIHBhcmFtZXRlciBzdWdnZXN0ZWQgYnkgamFuaQo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmMgfCAyMiArKysrKysrKysrKysrKysr KysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5oICAgICB8ICAxICsKPiAgMiBmaWxl cyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9taXBpX2RzaS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5jCj4gaW5k ZXggZjVkODA4My4uYzAyZDA4MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX21p cGlfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmMKPiBAQCAtOTgz LDYgKzk4MywyOCBAQCBpbnQgbWlwaV9kc2lfZGNzX3NldF90ZWFyX29uKHN0cnVjdCBtaXBpX2Rz aV9kZXZpY2UgKmRzaSwKPiAgRVhQT1JUX1NZTUJPTChtaXBpX2RzaV9kY3Nfc2V0X3RlYXJfb24p Owo+ICAKPiAgLyoqCj4gKyAqIG1pcGlfZHNpX3NldF90ZWFyX3NjYW5saW5lKCkgLSB0dXJuIG9u IHRoZSBkaXNwbGF5IG1vZHVsZSdzIFRlYXJpbmcgRWZmZWN0Cj4gKyAqIG91dHB1dCBzaWduYWwg b24gdGhlIFRFIHNpZ25hbCBsaW5lIHdoZW4gZGlzcGxheSBtb2R1bGUgcmVhY2hlcyBsaW5lIE4K PiArICogZGVmaW5lZCBieSBTVFNbbjowXS4KPiArICogQGRzaTogRFNJIHBlcmlwaGVyYWwgZGV2 aWNlCj4gKyAqIEBwYXJhbTogU1RTWzEwOjBdCj4gKyAqIFJldHVybjogMCBvbiBzdWNjZXNzIG9y IGEgbmVnYXRpdmUgZXJyb3IgY29kZSBvbiBmYWlsdXJlCj4gKyAqLwo+ICtpbnQgbWlwaV9kc2lf c2V0X3RlYXJfc2NhbmxpbmUoc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpLCB1MTYgcGFyYW0p Cj4gK3sKPiArCXU4IHBheWxvYWRbM10gPSB7IE1JUElfRENTX1NFVF9URUFSX1NDQU5MSU5FLCBw YXJhbSA+PiA4LAo+ICsJCQkgIHBhcmFtICYgMHhmZiB9Owo+ICsJc3NpemVfdCBlcnI7Cj4gKwo+ ICsJZXJyID0gbWlwaV9kc2lfZ2VuZXJpY193cml0ZShkc2ksICZwYXlsb2FkLCBzaXplb2YocGF5 bG9hZCkpOwoKWW91IGNhbiBqdXN0IHBhc3MgaW4gcGF5bG9hZCwgbm90ICZwYXlsb2FkLgoKQlIs CkphbmkuCgoKPiArCWlmIChlcnIgPCAwKQo+ICsJCXJldHVybiBlcnI7Cj4gKwo+ICsJcmV0dXJu IDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChtaXBpX2RzaV9zZXRfdGVhcl9zY2FubGluZSk7Cj4g Kwo+ICsvKioKPiAgICogbWlwaV9kc2lfZGNzX3NldF9waXhlbF9mb3JtYXQoKSAtIHNldHMgdGhl IHBpeGVsIGZvcm1hdCBmb3IgdGhlIFJHQiBpbWFnZQo+ICAgKiAgICBkYXRhIHVzZWQgYnkgdGhl IGludGVyZmFjZQo+ICAgKiBAZHNpOiBEU0kgcGVyaXBoZXJhbCBkZXZpY2UKPiBkaWZmIC0tZ2l0 IGEvaW5jbHVkZS9kcm0vZHJtX21pcGlfZHNpLmggYi9pbmNsdWRlL2RybS9kcm1fbWlwaV9kc2ku aAo+IGluZGV4IDdhOTg0MGYuLmVjNTUyODUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJt X21pcGlfZHNpLmgKPiArKysgYi9pbmNsdWRlL2RybS9kcm1fbWlwaV9kc2kuaAo+IEBAIC0yNjMs NiArMjYzLDcgQEAgaW50IG1pcGlfZHNpX2Rjc19zZXRfY29sdW1uX2FkZHJlc3Moc3RydWN0IG1p cGlfZHNpX2RldmljZSAqZHNpLCB1MTYgc3RhcnQsCj4gIAkJCQkgICAgdTE2IGVuZCk7Cj4gIGlu dCBtaXBpX2RzaV9kY3Nfc2V0X3BhZ2VfYWRkcmVzcyhzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpk c2ksIHUxNiBzdGFydCwKPiAgCQkJCSAgdTE2IGVuZCk7Cj4gK2ludCBtaXBpX2RzaV9zZXRfdGVh cl9zY2FubGluZShzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2ksIHUxNiBwYXJhbSk7Cj4gIGlu dCBtaXBpX2RzaV9kY3Nfc2V0X3RlYXJfb2ZmKHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRzaSk7 Cj4gIGludCBtaXBpX2RzaV9kY3Nfc2V0X3RlYXJfb24oc3RydWN0IG1pcGlfZHNpX2RldmljZSAq ZHNpLAo+ICAJCQkgICAgIGVudW0gbWlwaV9kc2lfZGNzX3RlYXJfbW9kZSBtb2RlKTsKCi0tIApK YW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbcFGGyM (ORCPT ); Tue, 7 Jun 2016 02:54:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:5497 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753592AbcFGGyK (ORCPT ); Tue, 7 Jun 2016 02:54:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,432,1459839600"; d="scan'208";a="996728047" From: Jani Nikula To: Vinay Simha BN Cc: Vinay Simha BN , Archit Taneja , John Stultz , Thierry Reding , Sumit Semwal , David Airlie , "open list\:DRM DRIVERS" , open list Subject: Re: [PATCH v2] drm/dsi: Implement set tear scanline In-Reply-To: <1465234897-21365-1-git-send-email-simhavcs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1465234897-21365-1-git-send-email-simhavcs@gmail.com> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 07 Jun 2016 09:54:06 +0300 Message-ID: <8737op7alt.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jun 2016, Vinay Simha BN wrote: > Provide a small convenience wrapper that transmits > a set_tear_scanline command. > > Also includes small build fixes from Sumit Semwal. > > Cc: Archit Taneja > Cc: John Stultz > Cc: Thierry Reding > Cc: Sumit Semwal > Cc: Jani Nikula > Signed-off-by: Vinay Simha BN > -- > v1: > * helper function suggested by Thierry > for set_tear_scanline > v2: > * one scanline parameter suggested by jani > --- > drivers/gpu/drm/drm_mipi_dsi.c | 22 ++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 23 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index f5d8083..c02d083 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -983,6 +983,28 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); > > /** > + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing Effect > + * output signal on the TE signal line when display module reaches line N > + * defined by STS[n:0]. > + * @dsi: DSI peripheral device > + * @param: STS[10:0] > + * Return: 0 on success or a negative error code on failure > + */ > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param) > +{ > + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param >> 8, > + param & 0xff }; > + ssize_t err; > + > + err = mipi_dsi_generic_write(dsi, &payload, sizeof(payload)); You can just pass in payload, not &payload. BR, Jani. > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); > + > +/** > * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image > * data used by the interface > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 7a9840f..ec55285 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -263,6 +263,7 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u16 param); > int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > enum mipi_dsi_dcs_tear_mode mode); -- Jani Nikula, Intel Open Source Technology Center