From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly Date: Mon, 25 Apr 2016 10:40:57 +0300 Message-ID: <8737qam8za.fsf@intel.com> References: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, linux-gpio@vger.kernel.org Cc: Alexandre Courbot , Samuel Ortiz , Shobhit Kumar , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Thierry Reding , Lee Jones , Linus Walleij List-Id: linux-gpio@vger.kernel.org T24gRnJpLCAyMiBBcHIgMjAxNiwgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20gd3JvdGU6 Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K Pgo+IEdQSU8gbG9va3VwIHRhYmxlcyBhcmUgc3VwcG9zZWQgdG8gYmUgemVybyB0ZXJtaW5hdGVk LiBMZXQncyBkbyB0aGF0Cj4gYW5kIGF2b2lkIGFjY2lkZW50YWxseSB3YWxraW5nIG9mZiB0aGUg ZW5kLgo+Cj4gQ2M6IFNob2JoaXQgS3VtYXIgPHNob2JoaXQua3VtYXJAaW50ZWwuY29tPgo+IENj OiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4KPiBDYzogTGludXMgV2FsbGVp aiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+IENjOiBBbGV4YW5kcmUgQ291cmJvdCA8Z251 cm91QGdtYWlsLmNvbT4KPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWls LmNvbT4KPiBDYzogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4KPiBDYzogc3RhYmxl QHZnZXIua2VybmVsLm9yZwo+IEZpeGVzOiA2MWRkMmNhMmQ0NGUgKCJtZmQ6IGludGVsX3NvY19w bWljX2NvcmU6IEFkZCBsb29rdXAgdGFibGUgZm9yIFBhbmVsIENvbnRyb2wgYXMgR1BJTyBzaWdu YWwiKQo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVs LmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvbWZkL2ludGVsX3NvY19wbWljX2NvcmUuYyB8IDEgKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L21mZC9pbnRlbF9zb2NfcG1pY19jb3JlLmMgYi9kcml2ZXJzL21mZC9pbnRlbF9zb2NfcG1pY19j b3JlLmMKPiBpbmRleCBkOWUxNWNmN2M2YzguLjEyZDZlYmI0YWU1ZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL21mZC9pbnRlbF9zb2NfcG1pY19jb3JlLmMKPiArKysgYi9kcml2ZXJzL21mZC9pbnRl bF9zb2NfcG1pY19jb3JlLmMKPiBAQCAtMzUsNiArMzUsNyBAQCBzdGF0aWMgc3RydWN0IGdwaW9k X2xvb2t1cF90YWJsZSBwYW5lbF9ncGlvX3RhYmxlID0gewo+ICAJLnRhYmxlID0gewo+ICAJCS8q IFBhbmVsIEVOL0RJU0FCTEUgKi8KPiAgCQlHUElPX0xPT0tVUCgiZ3Bpb19jcnlzdGFsY292ZSIs IDk0LCAicGFuZWwiLCBHUElPX0FDVElWRV9ISUdIKSwKPiArCQl7IH0sCj4gIAl9LAo+ICB9OwoK LS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:35866 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753828AbcDYHl1 convert rfc822-to-8bit (ORCPT ); Mon, 25 Apr 2016 03:41:27 -0400 From: Jani Nikula To: ville.syrjala@linux.intel.com, linux-gpio@vger.kernel.org Cc: Alexandre Courbot , Samuel Ortiz , Shobhit Kumar , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Thierry Reding , Lee Jones , Linus Walleij Subject: Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly In-Reply-To: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> References: <1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com> Date: Mon, 25 Apr 2016 10:40:57 +0300 Message-ID: <8737qam8za.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar > Cc: Samuel Ortiz > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Thierry Reding > Cc: Lee Jones > Cc: stable@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/mfd/intel_soc_pmic_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index d9e15cf7c6c8..12d6ebb4ae5d 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = { > .table = { > /* Panel EN/DISABLE */ > GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + { }, > }, > }; -- Jani Nikula, Intel Open Source Technology Center