From: Kalle Valo <kvalo@codeaurora.org>
To: Arend van Spriel <aspriel@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] brcmfmac: fix BRCMF_FW_NVRAM_DEF macro for older gcc compilers
Date: Mon, 18 Jan 2016 10:14:27 +0200 [thread overview]
Message-ID: <8737tv7198.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1452958753-12307-1-git-send-email-aspriel@gmail.com> (Arend van Spriel's message of "Sat, 16 Jan 2016 16:39:13 +0100")
Arend van Spriel <aspriel@gmail.com> writes:
> With gcc < 4.3 __UNIQUE_ID does not create unique ids with the macro
> BRCMF_FW_NVRAM_DEF. Fix this by removing the MODULE_FIRMWARE instance
> for the nvram file. This file is not in linux-firmware repo so it may
> not be needed anyway. Otherwise consider this as a temporary fix.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Arend van Spriel <aspriel@gmail.com>
Thanks. Geert, it would be great if you could test this.
Dave, if Geert says the patch is ok do you mind taking this directly? I
would like to fix this build breakage quickly.
https://patchwork.kernel.org/patch/8049181/
Acked-by: Kalle Valo <kvalo@codeaurora.org>
--
Kalle Valo
next prev parent reply other threads:[~2016-01-18 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-16 15:39 [PATCH] brcmfmac: fix BRCMF_FW_NVRAM_DEF macro for older gcc compilers Arend van Spriel
2016-01-18 8:14 ` Kalle Valo [this message]
2016-01-18 9:08 ` Geert Uytterhoeven
2016-01-18 9:27 ` Geert Uytterhoeven
2016-01-18 9:36 ` Arend van Spriel
2016-01-18 16:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737tv7198.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=aspriel@gmail.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.