From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbg64.qq.com (smtpbg64.qq.com [103.7.28.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 986071A0F00 for ; Tue, 8 Dec 2015 18:37:25 +1100 (AEDT) Received: from DZ-PC-031 (unknown [221.224.30.42]) by esmtp4.qq.com (ESMTP) with SMTP id 0 for ; Tue, 08 Dec 2015 15:30:06 +0800 (CST) Date: Tue, 8 Dec 2015 15:30:13 +0800 From: "wen.pu@powercore.com.cn" To: linuxppc-dev Subject: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type Mime-Version: 1.0 Message-ID: <20151208153012239673106@powercore.com.cn> Content-Type: multipart/alternative; boundary="----=_001_NextPart862661157014_=----" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. ------=_001_NextPart862661157014_=---- Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: base64 SSBmb3VuZCB0aGF0IHRoZXJlIGFyZSB1bmltcGxlbWVudGVkIE9QQUwgbWVzc2FnZSB0eXBlcyAi T1BBTF9NU0dfRVBPVyIgYW5kIA0KIk9QQUxfTVNHX0RQTyIgaW4gUG93ZXJOViBQbGF0Zm9ybS4g SWYgc2tpYm9vdCBzZW5kIHN1Y2ggbWVzc2FnZXMgdG8ga2VybmVsLCANCm5vdGhpbmcgd2lsbCBo YXBwZW4obm90aWZpZXJfY2FsbF9jaGFpbigpIHdpbGwgc2lsZW50bHkgZHJvcCBpdCkuIFNvIEkg YWRkIGEgd2FybmluZyANCnRvIGluZm9ybSB3aGF0IGhhcyBoYXBwZW5lZCwgaXMgaXQgbmVjZXNz YXJ5PyANCg0KU2lnbmVkLW9mZi1ieTogV2VuIFB1IDx3ZW4ucHVAcG93ZXJjb3JlLmNvbS5jbj4N Ci0tLQ0KZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcG93ZXJudi9vcGFsLmMg Yi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zL3Bvd2VybnYvb3BhbC5jDQppbmRleCBmMDg0YWZhLi5l ZjQ5OGFiIDEwMDY0NA0KLS0tIGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwu Yw0KKysrIGIvYXJjaC9wb3dlcnBjL3BsYXRmb3Jtcy9wb3dlcm52L29wYWwuYw0KQEAgLTI4MSw2 ICsyODEsMTAgQEAgc3RhdGljIHZvaWQgb3BhbF9oYW5kbGVfbWVzc2FnZSh2b2lkKQ0KICBwcl93 YXJuaW5nKCIlczogVW5rbm93biBtZXNzYWdlIHR5cGU6ICV1XG4iLCBfX2Z1bmNfXywgdHlwZSk7 DQogIHJldHVybjsNCiAgfQ0KKyBpZih0eXBlID09IE9QQUxfTVNHX0VQT1cgfHwgdHlwZSA9PSBP UEFMX01TR19EUE8pIHsNCisgcHJfd2FybmluZygiJXM6IFVuaW1wbGVtZW50ZWQgbWVzc2FnZSB0 eXBlOiAldVxuIiwgX19mdW5jX18sIHR5cGUpOw0KKyByZXR1cm47DQorIH0NCiAgb3BhbF9tZXNz YWdlX2RvX25vdGlmeSh0eXBlLCAodm9pZCAqKSZtc2cpOw0KIH0NCi0tLQ0KDQpUaGFua3MhDQpX ZW4gUHUNCg== ------=_001_NextPart862661157014_=---- Content-Type: text/html; charset="GB2312" Content-Transfer-Encoding: quoted-printable =0A
I found that there are unimple= mented OPAL message types "OPAL_MSG_EPOW" and 
"OPAL_MSG_DPO" in PowerNV Platform. If skiboot= send such messages to kernel, 
nothing will ha= ppen(notifier_call_chain() will silently drop it).= So I add a warning 
to inform what has happened, is it necessary? 

Signed-off-by: Wen Pu <wen.pu@powercore.com.cn>
---
=
diff --git a/arch/powerpc/platforms/powernv/opal.c b/a= rch/powerpc/platforms/powernv/opal.c
index f084afa..ef498ab 1= 00644
--- a/arch/powerpc/platforms/powernv/opal.c
+++ b/ar= ch/powerpc/platforms/powernv/opal.c
@@ -281,6 +281,10 @@=  static void opal_handle_message(void)
  p= r_warning("%s: Unknown message type: %u\n", __fun= c__, type);
  return;
  }
+ if(ty= pe =3D=3D OPAL_MSG_EPOW || type =3D=3D OPAL_= MSG_DPO) {
+ pr_warning("%s: Unimplemented mes= sage type: %u\n", __func__, type);
+ retur= n;
+ }
  opal_message_do_notify(type, (void *= )&msg);
 }
---
=0A

Thank= s!
Wen Pu
=0A ------=_001_NextPart862661157014_=------ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 022D61A1043 for ; Wed, 9 Dec 2015 11:17:13 +1100 (AEDT) Message-ID: <1449620232.6028.5.camel@ellerman.id.au> Subject: Re: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type From: Michael Ellerman To: "wen.pu@powercore.com.cn" , linuxppc-dev Date: Wed, 09 Dec 2015 11:17:12 +1100 In-Reply-To: <20151208153012239673106@powercore.com.cn> References: <20151208153012239673106@powercore.com.cn> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Wen, Thanks for the patch. On Tue, 2015-12-08 at 15:30 +0800, wen.pu@powercore.com.cn wrote: > I found that there are unimplemented OPAL message types "OPAL_MSG_EPOW" and > "OPAL_MSG_DPO" in PowerNV Platform. If skiboot send such messages to kernel, > nothing will happen(notifier_call_chain() will silently drop it). So I add a warning > to inform what has happened, is it necessary? What kernel version are you using? Looking at mainline (4.4-rc4), I do see handlers registered for EPOW and DPO: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/powerpc/platforms/powernv/opal-power.c?#n82 That code was merged in 4.3. In general I don't think we want to warn for unhandled message types, because we support old kernels running on new skiboot. In that case if we warned on every unhandled message we'd potentially spam the console with warnings. But perhaps we can come up with something smarter, that only warns once for each unhandled message type, or something like that? Did you have a bug that would have been easier to debug with a warning here? cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpbg64.qq.com (smtpbg64.qq.com [103.7.28.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3D8F01A1045 for ; Wed, 9 Dec 2015 19:56:57 +1100 (AEDT) From: Wen Pu To: Michael Ellerman , linuxppc-dev Subject: Re: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type Date: Wed, 09 Dec 2015 16:56:38 +0800 Message-ID: <2291635.sPXjXnnyi0@pw-vbox> In-Reply-To: <1449620232.6028.5.camel@ellerman.id.au> References: <20151208153012239673106@powercore.com.cn> <1449620232.6028.5.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Michael, On Wednesday, December 09, 2015 11:17:12 AM Michael Ellerman wrote: > Hi Wen, > > Thanks for the patch. > > On Tue, 2015-12-08 at 15:30 +0800, wen.pu@powercore.com.cn wrote: > > I found that there are unimplemented OPAL message types "OPAL_MSG_EPOW" > > and > > "OPAL_MSG_DPO" in PowerNV Platform. If skiboot send such messages to > > kernel, nothing will happen(notifier_call_chain() will silently drop it). > > So I add a warning to inform what has happened, is it necessary? > > What kernel version are you using? The kernel version is v4.2.1-openpower2, from the newest version at https://github.com/open-power/linux. > > Looking at mainline (4.4-rc4), I do see handlers registered for EPOW and > DPO: > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/p > owerpc/platforms/powernv/opal-power.c?#n82 > > That code was merged in 4.3. I do find that EPOW and DPO are registered in kernel 4.3. So maybe in the near future it will be merged into open-power/linux. > > > In general I don't think we want to warn for unhandled message types, > because we support old kernels running on new skiboot. In that case if we > warned on every unhandled message we'd potentially spam the console with > warnings. > > But perhaps we can come up with something smarter, that only warns once for > each unhandled message type, or something like that? Did you have a bug that > would have been easier to debug with a warning here? Yes, I think it is a good idea that only warns once, or warns every a few seconds. I found that EPOW and DPO only used in IBM FSP platform, not in Habanero platform that I had. So I modified the skiboot code and sent a EPOW/DPO message to kernel, and found that kernel warn nothing. I have no bug with a warning here, and just get a log message via dmesg. > > cheers Thanks! Wen Pu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpproxy21.qq.com (smtpbg297.qq.com [184.105.67.100]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0E2DE1A1047 for ; Wed, 9 Dec 2015 20:00:38 +1100 (AEDT) From: "=?utf-8?B?6JKy5paH?=" To: "=?utf-8?B?TWljaGFlbCBFbGxlcm1hbg==?=" , "=?utf-8?B?bGludXhwcGMtZGV2?=" Subject: Re: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_NextPart_5667EC65_0A5193F0_16903F29" Date: Wed, 9 Dec 2015 16:55:01 +0800 Message-ID: List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is a multi-part message in MIME format. ------=_NextPart_5667EC65_0A5193F0_16903F29 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTWljaGFlbCwNCg0KT24gV2VkbmVzZGF5LCBEZWNlbWJlciAwOSwgMjAxNSAxMToxNzox MiBBTSBNaWNoYWVsIEVsbGVybWFuIHdyb3RlOg0KPiBIaSBXZW4sDQo+IA0KPiBUaGFua3Mg Zm9yIHRoZSBwYXRjaC4NCj4gDQo+IE9uIFR1ZSwgMjAxNS0xMi0wOCBhdCAxNTozMCArMDgw MCwgd2VuLnB1QHBvd2VyY29yZS5jb20uY24gd3JvdGU6DQo+ID4gSSBmb3VuZCB0aGF0IHRo ZXJlIGFyZSB1bmltcGxlbWVudGVkIE9QQUwgbWVzc2FnZSB0eXBlcyAiT1BBTF9NU0dfRVBP VyINCj4gPiBhbmQNCj4gPiAiT1BBTF9NU0dfRFBPIiBpbiBQb3dlck5WIFBsYXRmb3JtLiBJ ZiBza2lib290IHNlbmQgc3VjaCBtZXNzYWdlcyB0bw0KPiA+IGtlcm5lbCwgbm90aGluZyB3 aWxsIGhhcHBlbihub3RpZmllcl9jYWxsX2NoYWluKCkgd2lsbCBzaWxlbnRseSBkcm9wIGl0 KS4NCj4gPiBTbyBJIGFkZCBhIHdhcm5pbmcgdG8gaW5mb3JtIHdoYXQgaGFzIGhhcHBlbmVk LCBpcyBpdCBuZWNlc3Nhcnk/DQo+IA0KPiBXaGF0IGtlcm5lbCB2ZXJzaW9uIGFyZSB5b3Ug dXNpbmc/DQpUaGUga2VybmVsIHZlcnNpb24gaXMgdjQuMi4xLW9wZW5wb3dlcjIsIGZyb20g dGhlIG5ld2VzdCB2ZXJzaW9uIGF0IA0KaHR0cHM6Ly9naXRodWIuY29tL29wZW4tcG93ZXIv bGludXguDQoNCj4gDQo+IExvb2tpbmcgYXQgbWFpbmxpbmUgKDQuNC1yYzQpLCBJIGRvIHNl ZSBoYW5kbGVycyByZWdpc3RlcmVkIGZvciBFUE9XIGFuZA0KPiBEUE86DQo+IA0KPiAgDQo+ IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRz L2xpbnV4LmdpdC90cmVlL2FyY2gvcA0KPiBvd2VycGMvcGxhdGZvcm1zL3Bvd2VybnYvb3Bh bC1wb3dlci5jPyNuODINCj4gDQo+IFRoYXQgY29kZSB3YXMgbWVyZ2VkIGluIDQuMy4NCkkg ZG8gZmluZCB0aGF0IEVQT1cgYW5kIERQTyBhcmUgcmVnaXN0ZXJlZCBpbiBrZXJuZWwgNC4z LiBTbyBtYXliZSBpbiB0aGUgbmVhciANCmZ1dHVyZSBpdCB3aWxsIGJlIG1lcmdlZCBpbnRv IG9wZW4tcG93ZXIvbGludXguDQoNCj4gDQo+IA0KPiBJbiBnZW5lcmFsIEkgZG9uJ3QgdGhp bmsgd2Ugd2FudCB0byB3YXJuIGZvciB1bmhhbmRsZWQgbWVzc2FnZSB0eXBlcywNCj4gYmVj YXVzZSB3ZSBzdXBwb3J0IG9sZCBrZXJuZWxzIHJ1bm5pbmcgb24gbmV3IHNraWJvb3QuIElu IHRoYXQgY2FzZSBpZiB3ZQ0KPiB3YXJuZWQgb24gZXZlcnkgdW5oYW5kbGVkIG1lc3NhZ2Ug d2UnZCBwb3RlbnRpYWxseSBzcGFtIHRoZSBjb25zb2xlIHdpdGgNCj4gd2FybmluZ3MuDQo+ IA0KPiBCdXQgcGVyaGFwcyB3ZSBjYW4gY29tZSB1cCB3aXRoIHNvbWV0aGluZyBzbWFydGVy LCB0aGF0IG9ubHkgd2FybnMgb25jZSBmb3INCj4gZWFjaCB1bmhhbmRsZWQgbWVzc2FnZSB0 eXBlLCBvciBzb21ldGhpbmcgbGlrZSB0aGF0PyBEaWQgeW91IGhhdmUgYSBidWcgdGhhdA0K PiB3b3VsZCBoYXZlIGJlZW4gZWFzaWVyIHRvIGRlYnVnIHdpdGggYSB3YXJuaW5nIGhlcmU/ DQpZZXMsIEkgdGhpbmsgaXQgaXMgYSBnb29kIGlkZWEgdGhhdCBvbmx5IHdhcm5zIG9uY2Us IG9yIHdhcm5zIGV2ZXJ5IGEgZmV3IA0Kc2Vjb25kcy4gDQpJIGZvdW5kIHRoYXQgRVBPVyBh bmQgRFBPIG9ubHkgdXNlZCBpbiBJQk0gRlNQIHBsYXRmb3JtLCBub3QgaW4gSGFiYW5lcm8g DQpwbGF0Zm9ybSB0aGF0IEkgaGFkLiBTbyBJIG1vZGlmaWVkIHRoZSBza2lib290IGNvZGUg YW5kIHNlbnQgYSBFUE9XL0RQTyBtZXNzYWdlIA0KdG8ga2VybmVsLCBhbmQgZm91bmQgdGhh dCBrZXJuZWwgd2FybiBub3RoaW5nLiBJIGhhdmUgbm8gYnVnIHdpdGggYSB3YXJuaW5nIA0K aGVyZSwgYW5kIGp1c3QgZ2V0IGEgbG9nIG1lc3NhZ2UgdmlhIGRtZXNnLg0KDQo+IA0KPiBj aGVlcnMNCg0KVGhhbmtzIQ0KV2VuIFB1 ------=_NextPart_5667EC65_0A5193F0_16903F29 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTWljaGFlbCw8YnI+PGJyPk9uIFdlZG5lc2RheSwgRGVjZW1iZXIgMDksIDIwMTUgMTE6 MTc6MTIgQU0gTWljaGFlbCBFbGxlcm1hbiB3cm90ZTo8YnI+Jmd0OyBIaSBXZW4sPGJyPiZn dDsgPGJyPiZndDsgVGhhbmtzIGZvciB0aGUgcGF0Y2guPGJyPiZndDsgPGJyPiZndDsgT24g VHVlLCAyMDE1LTEyLTA4IGF0IDE1OjMwICswODAwLCB3ZW4ucHVAcG93ZXJjb3JlLmNvbS5j biB3cm90ZTo8YnI+Jmd0OyAmZ3Q7IEkgZm91bmQgdGhhdCB0aGVyZSBhcmUgdW5pbXBsZW1l bnRlZCBPUEFMIG1lc3NhZ2UgdHlwZXMgIk9QQUxfTVNHX0VQT1ciPGJyPiZndDsgJmd0OyBh bmQ8YnI+Jmd0OyAmZ3Q7ICJPUEFMX01TR19EUE8iIGluIFBvd2VyTlYgUGxhdGZvcm0uIElm IHNraWJvb3Qgc2VuZCBzdWNoIG1lc3NhZ2VzIHRvPGJyPiZndDsgJmd0OyBrZXJuZWwsIG5v dGhpbmcgd2lsbCBoYXBwZW4obm90aWZpZXJfY2FsbF9jaGFpbigpIHdpbGwgc2lsZW50bHkg ZHJvcCBpdCkuPGJyPiZndDsgJmd0OyBTbyBJIGFkZCBhIHdhcm5pbmcgdG8gaW5mb3JtIHdo YXQgaGFzIGhhcHBlbmVkLCBpcyBpdCBuZWNlc3Nhcnk/PGJyPiZndDsgPGJyPiZndDsgV2hh dCBrZXJuZWwgdmVyc2lvbiBhcmUgeW91IHVzaW5nPzxicj5UaGUga2VybmVsIHZlcnNpb24g aXMgdjQuMi4xLW9wZW5wb3dlcjIsIGZyb20gdGhlIG5ld2VzdCB2ZXJzaW9uIGF0IDxicj5o dHRwczovL2dpdGh1Yi5jb20vb3Blbi1wb3dlci9saW51eC48YnI+PGJyPiZndDsgPGJyPiZn dDsgTG9va2luZyBhdCBtYWlubGluZSAoNC40LXJjNCksIEkgZG8gc2VlIGhhbmRsZXJzIHJl Z2lzdGVyZWQgZm9yIEVQT1cgYW5kPGJyPiZndDsgRFBPOjxicj4mZ3Q7IDxicj4mZ3Q7Jm5i c3A7IDxicj4mZ3Q7IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwv Z2l0L3RvcnZhbGRzL2xpbnV4LmdpdC90cmVlL2FyY2gvcDxicj4mZ3Q7IG93ZXJwYy9wbGF0 Zm9ybXMvcG93ZXJudi9vcGFsLXBvd2VyLmM/I244Mjxicj4mZ3Q7IDxicj4mZ3Q7IFRoYXQg Y29kZSB3YXMgbWVyZ2VkIGluIDQuMy48YnI+SSBkbyBmaW5kIHRoYXQgRVBPVyBhbmQgRFBP IGFyZSByZWdpc3RlcmVkIGluIGtlcm5lbCA0LjMuIFNvIG1heWJlIGluIHRoZSBuZWFyIDxi cj5mdXR1cmUgaXQgd2lsbCBiZSBtZXJnZWQgaW50byBvcGVuLXBvd2VyL2xpbnV4Ljxicj48 YnI+Jmd0OyA8YnI+Jmd0OyA8YnI+Jmd0OyBJbiBnZW5lcmFsIEkgZG9uJ3QgdGhpbmsgd2Ug d2FudCB0byB3YXJuIGZvciB1bmhhbmRsZWQgbWVzc2FnZSB0eXBlcyw8YnI+Jmd0OyBiZWNh dXNlIHdlIHN1cHBvcnQgb2xkIGtlcm5lbHMgcnVubmluZyBvbiBuZXcgc2tpYm9vdC4gSW4g dGhhdCBjYXNlIGlmIHdlPGJyPiZndDsgd2FybmVkIG9uIGV2ZXJ5IHVuaGFuZGxlZCBtZXNz YWdlIHdlJ2QgcG90ZW50aWFsbHkgc3BhbSB0aGUgY29uc29sZSB3aXRoPGJyPiZndDsgd2Fy bmluZ3MuPGJyPiZndDsgPGJyPiZndDsgQnV0IHBlcmhhcHMgd2UgY2FuIGNvbWUgdXAgd2l0 aCBzb21ldGhpbmcgc21hcnRlciwgdGhhdCBvbmx5IHdhcm5zIG9uY2UgZm9yPGJyPiZndDsg ZWFjaCB1bmhhbmRsZWQgbWVzc2FnZSB0eXBlLCBvciBzb21ldGhpbmcgbGlrZSB0aGF0PyBE aWQgeW91IGhhdmUgYSBidWcgdGhhdDxicj4mZ3Q7IHdvdWxkIGhhdmUgYmVlbiBlYXNpZXIg dG8gZGVidWcgd2l0aCBhIHdhcm5pbmcgaGVyZT88YnI+WWVzLCBJIHRoaW5rIGl0IGlzIGEg Z29vZCBpZGVhIHRoYXQgb25seSB3YXJucyBvbmNlLCBvciB3YXJucyBldmVyeSBhIGZldyA8 YnI+c2Vjb25kcy4gPGJyPkkgZm91bmQgdGhhdCBFUE9XIGFuZCBEUE8gb25seSB1c2VkIGlu IElCTSBGU1AgcGxhdGZvcm0sIG5vdCBpbiBIYWJhbmVybyA8YnI+cGxhdGZvcm0gdGhhdCBJ IGhhZC4gU28gSSBtb2RpZmllZCB0aGUgc2tpYm9vdCBjb2RlIGFuZCBzZW50IGEgRVBPVy9E UE8gbWVzc2FnZSA8YnI+dG8ga2VybmVsLCBhbmQgZm91bmQgdGhhdCBrZXJuZWwgd2FybiBu b3RoaW5nLiBJIGhhdmUgbm8gYnVnIHdpdGggYSB3YXJuaW5nIDxicj5oZXJlLCBhbmQganVz dCBnZXQgYSBsb2cgbWVzc2FnZSB2aWEgZG1lc2cuPGJyPjxicj4mZ3Q7IDxicj4mZ3Q7IGNo ZWVyczxicj48YnI+VGhhbmtzITxicj5XZW4gUHU8IS0tPCFbZW5kaWZdLS0+ ------=_NextPart_5667EC65_0A5193F0_16903F29-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 8F1AD1A0809 for ; Fri, 11 Dec 2015 11:51:44 +1100 (AEDT) Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Dec 2015 19:51:41 -0500 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id F04806E803C for ; Thu, 10 Dec 2015 19:39:48 -0500 (EST) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tBB0pd8e28639312 for ; Fri, 11 Dec 2015 00:51:39 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tBB0pdtR006019 for ; Thu, 10 Dec 2015 19:51:39 -0500 From: Stewart Smith To: =?utf-8?B?6JKy5paH?= , Michael Ellerman , linuxppc-dev Subject: Re: [PATCH] powerpc/opal: add warning for unimplemented OPAL message type In-Reply-To: References: Date: Fri, 11 Dec 2015 11:51:23 +1100 Message-ID: <8737v9byes.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , =E8=92=B2=E6=96=87 writes: > On Wednesday, December 09, 2015 11:17:12 AM Michael Ellerman wrote: >> On Tue, 2015-12-08 at 15:30 +0800, wen.pu@powercore.com.cn wrote: >> > I found that there are unimplemented OPAL message types "OPAL_MSG_EPOW" >> > and >> > "OPAL_MSG_DPO" in PowerNV Platform. If skiboot send such messages to >> > kernel, nothing will happen(notifier_call_chain() will silently drop i= t). >> > So I add a warning to inform what has happened, is it necessary? >>=20 >> What kernel version are you using? > The kernel version is v4.2.1-openpower2, from the newest version at=20 > https://github.com/open-power/linux. > >>=20 >> Looking at mainline (4.4-rc4), I do see handlers registered for EPOW and >> DPO: >>=20 >>=20=20 >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arc= h/p >> owerpc/platforms/powernv/opal-power.c?#n82 >>=20 >> That code was merged in 4.3. > I do find that EPOW and DPO are registered in kernel 4.3. So maybe in the= near=20 > future it will be merged into open-power/linux. Way back in 24366360035a9e0a9870ed7208aa2ba1948f844d where the opal_msg code was introduced there was a warning added for opal messages that were unknown... arguably this is actually a bad thing to have these days... I'll submit a patch to print it *once*. >> In general I don't think we want to warn for unhandled message types, >> because we support old kernels running on new skiboot. In that case if we >> warned on every unhandled message we'd potentially spam the console with >> warnings. >>=20 >> But perhaps we can come up with something smarter, that only warns once = for >> each unhandled message type, or something like that? Did you have a bug = that >> would have been easier to debug with a warning here? > Yes, I think it is a good idea that only warns once, or warns every a few= =20 > seconds.=20 > I found that EPOW and DPO only used in IBM FSP platform, not in Habanero= =20 > platform that I had. So I modified the skiboot code and sent a EPOW/DPO m= essage=20 > to kernel, and found that kernel warn nothing. I have no bug with a warni= ng=20 > here, and just get a log message via dmesg. Currently only FSP platform, yes. No real reason why a BMC based platform couldn't emit those though.