From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2HfC-0000kx-9a for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:58:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Hf7-00031b-TP for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:58:06 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:32858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Hf7-00031W-Kt for qemu-devel@nongnu.org; Fri, 27 Nov 2015 06:58:01 -0500 Received: by wmec201 with SMTP id c201so67346725wme.0 for ; Fri, 27 Nov 2015 03:58:01 -0800 (PST) References: <1664220.kcr3K9QWbf@dabox> <87si3sbpnc.fsf@linaro.org> <1727507.5NJ00yyck5@dabox> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1727507.5NJ00yyck5@dabox> Date: Fri, 27 Nov 2015 11:57:59 +0000 Message-ID: <8737vr7iyg.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC] i2c-tiny-usb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tim Sander Cc: Paolo Bonzini , qemu-devel@nongnu.org, Gerd Hoffmann Tim Sander writes: > Hi Alex > > Thanks for your feedback, answers as usual inline. > > Am Donnerstag, 26. November 2015, 18:07:35 schrieb Alex Bennée: >> Tim Sander writes: >> > Hi >> > >> You are missing a s-o-b line and scripts/checkpatch.pl complains about a >> few things you should fix before your next submission. > I was unsure about the access length so i was just asking for feedback this > time, thats why omitted the signed of by line. > It seems as if i grabbed an older version of checkpatch as these errors didn't > come up with the slightly older script. These new occurences will be fixed. Cool. FWIW I always run against the current $(QEMU_SRC)/scripts/checkpatch.pl as it is updated reasonably frequently. -- Alex Bennée