From: Felipe Balbi <balbi@ti.com>
To: Nathan Sullivan <nathan.sullivan@ni.com>, <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Nathan Sullivan <nathan.sullivan@ni.com>
Subject: Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG
Date: Tue, 3 Nov 2015 07:56:55 -0600 [thread overview]
Message-ID: <8737wnnq3c.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <1446126743-31892-1-git-send-email-nathan.sullivan@ni.com>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
Hi,
Nathan Sullivan <nathan.sullivan@ni.com> writes:
> The USB OTG support currently depends on power management
> (CONFIG_PM) being enabled, but does not actually need it enabled.
> Remove this dependency.
>
> Tested on Bay Trail hardware with dwc3 USB.
>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
> drivers/usb/core/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index a99c89e..9c5cdf3 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS
>
> config USB_OTG
> bool "OTG support"
> - depends on PM
I don't think this is correct. OTG depends on USB bus suspend, which is
only available on PM builds. Care to further detail why you think PM is
not needed on OTG ?
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-11-03 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 13:52 [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG Nathan Sullivan
2015-11-03 8:40 ` Peter Chen
2015-11-03 13:56 ` Felipe Balbi [this message]
2015-11-03 14:53 ` Nathan Sullivan
2015-11-03 15:05 ` Felipe Balbi
2015-11-04 3:00 ` Peter Chen
2015-11-04 3:51 ` Felipe Balbi
2015-11-05 2:13 ` Peter Chen
2015-11-05 14:36 ` Felipe Balbi
2015-12-01 10:50 ` Li Jun
2015-12-01 14:25 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737wnnq3c.fsf@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.