From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Conole Subject: Re: [PATCH] net/unix: fix logic about sk_peek_offset Date: Sun, 04 Oct 2015 08:50:02 -0400 Message-ID: <8737xq3iit.fsf@bytheb.org> References: <1443733536-992-1-git-send-email-avagin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org, Andrey Vagin , "David S. Miller" , Eric Dumazet To: Andrey Vagin Return-path: Received: from mail-qk0-f179.google.com ([209.85.220.179]:33746 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbbJDMuG (ORCPT ); Sun, 4 Oct 2015 08:50:06 -0400 Received: by qkas79 with SMTP id s79so60087031qka.0 for ; Sun, 04 Oct 2015 05:50:05 -0700 (PDT) In-Reply-To: <1443733536-992-1-git-send-email-avagin@gmail.com> (Andrey Vagin's message of "Fri, 2 Oct 2015 00:05:36 +0300") Sender: netdev-owner@vger.kernel.org List-ID: Andrey Vagin writes: > From: Andrey Vagin > > Now send with MSG_PEEK can return data from multiple SKBs. > > Unfortunately we take into account the peek offset for each skb, > that is wrong. We need to apply the peek offset only once. > > In addition, the peek offset should be used only if MSG_PEEK is set. > > Cc: "David S. Miller" (maintainer:NETWORKING > Cc: Eric Dumazet (commit_signer:1/14=7%) > Cc: Aaron Conole > Fixes: 9f389e35674f ("af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag") > Signed-off-by: Andrey Vagin > --- Tested-by: Aaron Conole Thanks again!