From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] micropython: fix build for MIPS64 n32
Date: Wed, 23 Sep 2015 23:12:30 +0200 [thread overview]
Message-ID: <8737y4rgap.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1442997860-1402-1-git-send-email-Vincent.Riera@imgtec.com> (Vicente Olivert Riera's message of "Wed, 23 Sep 2015 09:44:20 +0100")
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> This patch applies an upstream patch to fix a compile error like this
> one:
> modffi.c: In function 'ffifunc_call':
> modffi.c:358:25: error: cast from pointer to integer of different size
> [-Werror=pointer-to-int-cast]
> values[i] = (ffi_arg)a;
> This error can be highlighted when building micropython for MIPS64 n32
> because ffi_arg is 64-bit wide and the pointers on MIPS64 n32 are 32-bit
> wide, so it's trying to case an integer to a pointer (or vice versa) of
> a different size. We should cast first the pointer (or the integer) to a
> pointer sized integer (intptr_t) to fix that problem.
> This patch was merged upstream as a result of this pull request:
> https://github.com/micropython/micropython/pull/1471
> Fixes:
> http://autobuild.buildroot.net/results/e22/e2253de3f96e9a53e75b4cecaf56c1df2950803f/
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Committed, thanks.
If we need to apply any more patches then I think it makes more sense to
get the sources from git (or convince upstream to make a new release).
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2015-09-23 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 8:44 [Buildroot] [PATCHv2] micropython: fix build for MIPS64 n32 Vicente Olivert Riera
2015-09-23 21:11 ` Thomas Petazzoni
2015-09-23 21:15 ` Vicente Olivert Riera
2015-09-23 21:12 ` Peter Korsgaard [this message]
2015-09-23 23:12 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737y4rgap.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.