All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Sonika Jindal <sonika.jindal@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Sink rate read should be saved in	deca-kHz
Date: Thu, 07 May 2015 11:58:45 +0300	[thread overview]
Message-ID: <8738387ohm.fsf@intel.com> (raw)
In-Reply-To: <1430987368-31740-1-git-send-email-sonika.jindal@intel.com>

On Thu, 07 May 2015, Sonika Jindal <sonika.jindal@intel.com> wrote:
> The sink rate read from supported link rate table is in KHz as per spec
> while in drm, the saved clock is in deca-KHz. So divide the link rate by
> 10 before storing.
>
> Reading of rates was added by:
> commit fc0f8e25318f ("drm/i915/skl: Read sink supported rates from edp
> panel")

Thanks; now this git spell

$ git tag --contains fc0f8e25318f | grep ^v[0-9] | sort -V | head -n 1
v4.1-rc1

will tell me I need to queue this one to v4.1 through drm-intel-fixes
while the rest is for Daniel to merge to drm-intel-next-queued.

Pushed, thanks for the patch and review.

BR,
Jani.


>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index bacdec5..6bd5afb 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -3906,7 +3906,8 @@ intel_dp_get_dpcd(struct intel_dp *intel_dp)
>  			if (val == 0)
>  				break;
>  
> -			intel_dp->sink_rates[i] = val * 200;
> +			/* Value read is in kHz while drm clock is saved in deca-kHz */
> +			intel_dp->sink_rates[i] = (val * 200) / 10;
>  		}
>  		intel_dp->num_sink_rates = i;
>  	}
> -- 
> 1.7.10.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-05-07  8:56 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07  4:22 [PATCH 1/3] drm/i915: Sink rate read should be saved in deca-kHz Sonika Jindal
2015-05-07  4:22 ` [PATCH 2/3] drm/i915: Rename dp rates array as per platform Sonika Jindal
2015-05-07  8:35   ` Ville Syrjälä
2015-05-07 13:19     ` Daniel Vetter
2015-05-07  4:22 ` [PATCH 3/3] drm/i915/bxt: edp1.4 Intermediate Freq support Sonika Jindal
2015-05-07  8:41   ` Ville Syrjälä
2015-05-07  8:57     ` Jindal, Sonika
2015-05-07 11:06       ` [PATCH] " Sonika Jindal
2015-05-07 15:34         ` Ville Syrjälä
2015-05-08  5:34           ` Sonika Jindal
2015-05-08 12:26             ` Ville Syrjälä
2015-05-11  7:51               ` Sonika Jindal
2015-05-11  9:51                 ` Daniel Vetter
2015-05-14 13:30                 ` shuang.he
2015-05-26  9:21               ` Sonika Jindal
2015-05-26  9:48                 ` Daniel Vetter
2015-05-26  9:57                   ` Jani Nikula
2015-05-26  9:59                     ` Daniel Vetter
2015-05-26 10:21                       ` Jindal, Sonika
2015-05-26 12:20                         ` Sonika Jindal
2015-06-03  5:19                           ` Jindal, Sonika
2015-06-03  6:31                           ` Kannan, Vandana
2015-06-03  8:00                             ` Jani Nikula
2015-05-26  9:54                 ` Jani Nikula
2015-05-08 19:30             ` shuang.he
2015-05-08  7:39         ` shuang.he
2015-05-07 19:04   ` [PATCH 3/3] " shuang.he
2015-05-07  8:10 ` [PATCH 1/3] drm/i915: Sink rate read should be saved in deca-kHz Jani Nikula
2015-05-07  8:34   ` Ville Syrjälä
2015-05-07  8:29     ` [PATCH] " Sonika Jindal
2015-05-07  8:58       ` Jani Nikula [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-04-21  5:33 Sonika Jindal
2015-04-21 10:31 ` shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738387ohm.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sonika.jindal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.