From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: linux-mtd@lists.infradead.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt
Date: Wed, 18 Feb 2015 17:09:52 +0100 [thread overview]
Message-ID: <8738639p67.fsf@free.fr> (raw)
In-Reply-To: <54E47ABF.8070306@free-electrons.com> (Ezequiel Garcia's message of "Wed, 18 Feb 2015 08:42:55 -0300")
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> writes:
>> +static irqreturn_t pxa3xx_nand_irq_thread(int irq, void *data)
>> +{
>> + struct pxa3xx_nand_info *info = data;
>> +
>> + handle_data_pio(info);
>> +
>> + info->state = STATE_CMD_DONE;
>
> Are you sure you need to set the state here?
Euh no, I'm not. I made it to be symmetric with dma_complete_func(). If it's not
needed, why is it needed in dma_complete_func() ?
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt
Date: Wed, 18 Feb 2015 17:09:52 +0100 [thread overview]
Message-ID: <8738639p67.fsf@free.fr> (raw)
In-Reply-To: <54E47ABF.8070306@free-electrons.com> (Ezequiel Garcia's message of "Wed, 18 Feb 2015 08:42:55 -0300")
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> writes:
>> +static irqreturn_t pxa3xx_nand_irq_thread(int irq, void *data)
>> +{
>> + struct pxa3xx_nand_info *info = data;
>> +
>> + handle_data_pio(info);
>> +
>> + info->state = STATE_CMD_DONE;
>
> Are you sure you need to set the state here?
Euh no, I'm not. I made it to be symmetric with dma_complete_func(). If it's not
needed, why is it needed in dma_complete_func() ?
Cheers.
--
Robert
next prev parent reply other threads:[~2015-02-18 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 20:06 [PATCH] mtd: pxa3xx-nand: handle PIO in threaded interrupt Robert Jarzmik
2015-02-17 20:06 ` Robert Jarzmik
2015-02-18 10:16 ` Maxime Ripard
2015-02-18 10:16 ` Maxime Ripard
2015-02-18 17:16 ` Robert Jarzmik
2015-02-18 17:16 ` Robert Jarzmik
2015-02-19 11:17 ` Maxime Ripard
2015-02-19 11:17 ` Maxime Ripard
2015-02-18 11:42 ` Ezequiel Garcia
2015-02-18 16:09 ` Robert Jarzmik [this message]
2015-02-18 16:09 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738639p67.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.