From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35400)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XuNtj-0005Kj-24
	for qemu-devel@nongnu.org; Fri, 28 Nov 2014 10:56:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XuNtc-0003hS-MY
	for qemu-devel@nongnu.org; Fri, 28 Nov 2014 10:55:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51990)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1XuNtc-0003h1-Fg
	for qemu-devel@nongnu.org; Fri, 28 Nov 2014 10:55:48 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sASFtklX013346
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Fri, 28 Nov 2014 10:55:46 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1416227466-29491-1-git-send-email-mreitz@redhat.com>
Date: Fri, 28 Nov 2014 16:55:44 +0100
In-Reply-To: <1416227466-29491-1-git-send-email-mreitz@redhat.com> (Max
	Reitz's message of "Mon, 17 Nov 2014 13:31:03 +0100")
Message-ID: <8738931fr3.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

Copying Luiz.

Max Reitz <mreitz@redhat.com> writes:

> This series does not add new functionality. Adding a QMP monitor with
> prettily formatted JSON output can be done as follows:
>
> $ qemu -chardev stdio,id=mon0 -mon chardev=mon0,mode=control,pretty=on
>
> However, this is rather cumbersome, so this series (its first patch)
> adds a shortcut in the form of the new command line option -qmp-pretty.
>
> Since the argument given to a monitor command line option (such as -qmp)
> is parsed depending on its prefix and probably also depending on the
> current phase of the moon, this is cleaner than trying to add a "switch"
> to -qmp itself (in the form of "-qmp stdio,pretty=on").

Yet another "convenience" option *groan*

Why can't we simply make -qmp set pretty=on and be done with it?
It's a convenience option, i.e. meant for humans, and why would humans
*not* want pretty=on?