From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/get_maintainer.pl: allow "odd fixes"
Date: Wed, 22 Oct 2014 10:07:12 +0200 [thread overview]
Message-ID: <8738agil3j.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <54476397.3020808@redhat.com> (Paolo Bonzini's message of "Wed, 22 Oct 2014 09:58:15 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 10/22/2014 09:47 AM, Markus Armbruster wrote:
>> Like this:
>>
>> $ scripts/get_maintainer.pl -f --no-git-fallback hw/ide/core.c
>> Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
>> Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)
>>
>> What's wrong with that?
>
> Michael's patch fixes the case where you do _not_ have --no-git-fallback:
>
> $ scripts/get_maintainer.pl -f hw/ide/core.c
> Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE,commit_signer:6/27=22%)
> Stefan Hajnoczi <stefanha@redhat.com> (odd
> fixer:IDE,commit_signer:18/27=67%)
> John Snow <jsnow@redhat.com> (commit_signer:13/27=48%)
> Paolo Bonzini <pbonzini@redhat.com> (commit_signer:11/27=41%)
> Fam Zheng <famz@redhat.com> (commit_signer:4/27=15%)
>
> With the patch:
>
> $ scripts/get_maintainer.pl -f hw/ide/core.c
> Kevin Wolf <kwolf@redhat.com> (odd fixer:IDE)
> Stefan Hajnoczi <stefanha@redhat.com> (odd fixer:IDE)
>
> which behaves the same as:
>
> $ scripts/get_maintainer.pl -f block/qed.c
> Kevin Wolf <kwolf@redhat.com> (supporter:Block)
> Stefan Hajnoczi <stefanha@redhat.com> (supporter:Block)
Got it, thanks!
Shows how automatic --no-git-fallback has become for me...
>> > So this boils down to the fact that we use
>> > "odd fixer" incorrectly.
>> >
>> > I will apply this for now but maybe we should
>> > change MAINTAINERS switching all "Odd fixes" to
>> > "Maintained" and then revert this patch.
>> >
>> > Thoughts?
>>
>> What exactly does this patch fix?
No objections to applying the patch.
prev parent reply other threads:[~2014-10-22 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 11:35 [Qemu-devel] [PATCH] scripts/get_maintainer.pl: allow "odd fixes" Michael S. Tsirkin
2014-10-21 16:55 ` Don Slutz
2014-10-22 7:22 ` Michael S. Tsirkin
2014-10-22 7:45 ` Paolo Bonzini
2014-10-22 8:08 ` Michael S. Tsirkin
2014-10-22 8:07 ` Paolo Bonzini
2014-10-22 8:13 ` Michael S. Tsirkin
2014-10-22 8:18 ` Paolo Bonzini
2014-10-22 7:47 ` Markus Armbruster
2014-10-22 7:58 ` Paolo Bonzini
2014-10-22 8:07 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738agil3j.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.