From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Xbmht-0007bD-6d
	for qemu-devel@nongnu.org; Wed, 08 Oct 2014 04:34:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Xbmho-0001zO-CU
	for qemu-devel@nongnu.org; Wed, 08 Oct 2014 04:34:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Xbmho-0001zH-5s
	for qemu-devel@nongnu.org; Wed, 08 Oct 2014 04:34:44 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1411983695-7910-1-git-send-email-dgilbert@redhat.com>
	<1411983695-7910-2-git-send-email-dgilbert@redhat.com>
	<5434A6D7.50209@huawei.com> <20141008082340.GC2521@work-vm>
Date: Wed, 08 Oct 2014 10:34:29 +0200
In-Reply-To: <20141008082340.GC2521@work-vm> (David Alan Gilbert's message of
	"Wed, 8 Oct 2014 09:23:41 +0100")
Message-ID: <8738aznene.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v5 1/2] QEMUSizedBuffer based QEMUFile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: joel.schopp@amd.com, zhanghailiang <zhang.zhanghailiang@huawei.com>, stefanb@linux.vnet.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, sanidhya.iiith@gmail.com

"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:

> * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote:
>> On 2014/9/29 17:41, Dr. David Alan Gilbert (git) wrote:
>
>> >+static ssize_t qsb_grow(QEMUSizedBuffer *qsb, size_t new_size)
>> >+{
>> >+    size_t needed_chunks, i;
>> >+
>> >+    if (qsb->size < new_size) {
>> >+        struct iovec *new_iov;
>> >+        size_t size_diff = new_size - qsb->size;
>> >+        size_t chunk_size = (size_diff > QSB_MAX_CHUNK_SIZE)
>> >+                             ? QSB_MAX_CHUNK_SIZE : QSB_CHUNK_SIZE;
>> >+
>> >+        needed_chunks = DIV_ROUND_UP(size_diff, chunk_size);
>> >+
>> >+        new_iov = g_try_malloc_n(qsb->n_iov + needed_chunks,
>> >+                                 sizeof(struct iovec));
>> 
>> It seems that *g_try_malloc_n* was supported since glib2-2.24 version,
>> But it don't check this when do *configure* before compile...;)
>
> OK, that's a shame - it was a nice easy function to use :-)
> I'll fix it.

See also commit 02c4f26.