All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] e2fsprogs: fix static build against external libblkid
Date: Wed, 11 Jun 2014 14:53:45 +0200	[thread overview]
Message-ID: <8738fbip46.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20140611123159.GX4074@tarshish> (Baruch Siach's message of "Wed,  11 Jun 2014 15:31:59 +0300")

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

Hi,

 >> > +Patch status: sent upstream: http://patchwork.ozlabs.org/patch/358584/
 >> > +
 >> > + configure.in | 2 +-
 >> > + 1 file changed, 1 insertion(+), 1 deletion(-)
 >> > +
 >> > +diff --git a/configure.in b/configure.in
 >> > +index 448a2926776a..ec6068320878 100644
 >> > +--- a/configure.in
 >> > ++++ b/configure.in
 >> > +@@ -551,7 +551,7 @@ then
 >> > + 		[LIBBLKID=`$PKG_CONFIG --libs blkid`;
 >> > + 		 STATIC_LIBBLKID=`$PKG_CONFIG --static --libs blkid`],
 >> > + 		[AC_MSG_ERROR([external blkid library not found])],
 >> > +-		[$LIBBLKID])
 >> > ++		[`$PKG_CONFIG --static --libs blkid`])
 >> 
 >> Why not '[$STATIC_LIBBLKID])' instead of rerunning pkg-config?

 > Quoting the autoconf manual:

 > AC_CHECK_LIB (LIBRARY, FUNCTION, [ACTION-IF-FOUND],
 > 		  [ACTION-IF-NOT-FOUND], [OTHER-LIBRARIES])

 > So, if I understand correctly, $STATIC_LIBBLKID in [ACTION-IF-FOUND] gets 
 > defined only after the test has run successfully.

Sorry, you're right - I misread the patch. It should arguably still pass
$LIBBLKID so the user can pass extra libraries, but looking at the
configure script I see it clears it just above, so it cannot be used
anyway.

Committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2014-06-11 12:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 10:15 [Buildroot] [PATCH] e2fsprogs: fix static build against external libblkid Baruch Siach
2014-06-11 10:52 ` Peter Korsgaard
2014-06-11 12:31   ` Baruch Siach
2014-06-11 12:53     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738fbip46.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.