All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash
Date: Tue, 25 Mar 2014 08:52:14 +0200	[thread overview]
Message-ID: <8738i64voh.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20140321143737.GA5140@mwanda> (Dan Carpenter's message of "Fri,  21 Mar 2014 17:37:38 +0300")

Dan Carpenter <dan.carpenter@oracle.com> writes:

>> drivers/net/wireless/ath/ath10k/debug.c:500 ath10k_write_simulate_fw_crash() error: strncmp() '"hard"' too small (5 vs 32)
>> drivers/net/wireless/ath/ath10k/debug.c:497 ath10k_write_simulate_fw_crash() error: strncmp() '"soft"' too small (5 vs 32)
>> 
>> I wanted to use strncmp() instead of strcmp(), but I'm not sure what to
>> do here. In my opinion it's guaranteed that the string "hard" is null
>> terminated, so it shouldn't matter even if strlen("soft") (5) is less
>> than sizeof(buf) (32), right? Or am I missing something here?
>> 
>
> I am on vacation until next week.  I didn't think these particular
> emails went out automatically.

Actually that's true. Fengguang's bot sends me a build report after
every build and I saw these warnings in that report.

> Anyway, I have changed this in the latest smatch but it will take some
> months for the kbuild bot to update.
>
> http://repo.or.cz/w/smatch.git/commitdiff/f10f27a7612c5b1e69b5d9080a0194d012beb6aa
>
> I'll take a closer look next week.

Thanks!

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash
Date: Tue, 25 Mar 2014 08:52:14 +0200	[thread overview]
Message-ID: <8738i64voh.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20140321143737.GA5140@mwanda> (Dan Carpenter's message of "Fri, 21 Mar 2014 17:37:38 +0300")

Dan Carpenter <dan.carpenter@oracle.com> writes:

>> drivers/net/wireless/ath/ath10k/debug.c:500 ath10k_write_simulate_fw_crash() error: strncmp() '"hard"' too small (5 vs 32)
>> drivers/net/wireless/ath/ath10k/debug.c:497 ath10k_write_simulate_fw_crash() error: strncmp() '"soft"' too small (5 vs 32)
>> 
>> I wanted to use strncmp() instead of strcmp(), but I'm not sure what to
>> do here. In my opinion it's guaranteed that the string "hard" is null
>> terminated, so it shouldn't matter even if strlen("soft") (5) is less
>> than sizeof(buf) (32), right? Or am I missing something here?
>> 
>
> I am on vacation until next week.  I didn't think these particular
> emails went out automatically.

Actually that's true. Fengguang's bot sends me a build report after
every build and I saw these warnings in that report.

> Anyway, I have changed this in the latest smatch but it will take some
> months for the kbuild bot to update.
>
> http://repo.or.cz/w/smatch.git/commitdiff/f10f27a7612c5b1e69b5d9080a0194d012beb6aa
>
> I'll take a closer look next week.

Thanks!

-- 
Kalle Valo

  reply	other threads:[~2014-03-25  6:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13  8:24 [PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash Kalle Valo
2014-03-13  8:24 ` Kalle Valo
2014-03-14 10:39 ` Kalle Valo
2014-03-14 10:39   ` Kalle Valo
2014-03-14 11:38   ` Marek Puzyniak
2014-03-14 11:38     ` Marek Puzyniak
2014-03-19  9:06 ` Kalle Valo
2014-03-19  9:06   ` Kalle Valo
2014-03-19  9:16   ` Michal Kazior
2014-03-19  9:16     ` Michal Kazior
2014-03-19 12:41     ` Jouni Malinen
2014-03-19 12:41       ` Jouni Malinen
2014-03-20  7:51       ` Kalle Valo
2014-03-20  7:51         ` Kalle Valo
2014-03-21 14:37   ` Dan Carpenter
2014-03-21 14:37     ` Dan Carpenter
2014-03-25  6:52     ` Kalle Valo [this message]
2014-03-25  6:52       ` Kalle Valo
2014-03-26 11:40       ` Dan Carpenter
2014-03-26 11:40         ` Dan Carpenter
2014-03-24  8:25 ` Kalle Valo
2014-03-24  8:25   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738i64voh.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.