From: Jani Nikula <jani.nikula@linux.intel.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Increase OpRegion timeout
Date: Fri, 31 Jan 2014 13:42:26 +0200 [thread overview]
Message-ID: <8738k44btp.fsf@intel.com> (raw)
In-Reply-To: <1391160676-26766-1-git-send-email-daniel.vetter@ffwll.ch>
On Fri, 31 Jan 2014, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> I have a machine here which hits this (a g33):
>
> [ 13.368536] excessive driver sleep timeout (DSPL) 1024
>
> Apparently people love pot numbers, and one second isn't that
> unreasonable (for a bios writer at least) I guess.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 3da259e280ba..3c7e38c7ed87 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -261,10 +261,10 @@ static int swsci(struct drm_device *dev, u32 function, u32 parm, u32 *parm_out)
> /* The spec says 2ms should be the default, but it's too small
> * for some machines. */
> dslp = 50;
> - } else if (dslp > 500) {
> + } else if (dslp > 1500) {
> /* Hey bios, trust must be earned. */
> WARN_ONCE(1, "excessive driver sleep timeout (DSPL) %u\n", dslp);
> - dslp = 500;
> + dslp = 1500;
> }
>
> /* The spec tells us to do this, but we are the only user... */
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
prev parent reply other threads:[~2014-01-31 11:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 9:31 [PATCH] drm/i915: Increase OpRegion timeout Daniel Vetter
2014-01-31 9:38 ` Chris Wilson
2014-01-31 11:41 ` [PATCH] drm/i915: demote opregion excessive timeout WARN_ONCE to DRM_INFO Jani Nikula
2014-01-31 11:41 ` Ville Syrjälä
2014-01-31 13:21 ` Jani Nikula
2014-01-31 13:26 ` Ville Syrjälä
2014-01-31 11:43 ` Chris Wilson
2014-01-31 11:55 ` Jani Nikula
2014-01-31 11:56 ` Chris Wilson
2014-01-31 13:49 ` [PATCH 1/2] drm: add DRM_INFO_ONCE() to print a one-time DRM_INFO() message Jani Nikula
2014-01-31 13:49 ` [PATCH 2/2] drm/i915: demote opregion excessive timeout WARN_ONCE to DRM_INFO_ONCE Jani Nikula
2014-01-31 13:48 ` Chris Wilson
2014-02-04 20:09 ` Daniel Vetter
2014-01-31 11:42 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738k44btp.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.