From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno@natisbad.org (Arnaud Ebalard) Date: Mon, 11 Nov 2013 21:07:41 +0100 Subject: [PATCH] ARM: mvebu: Add RN104 SATA LEDs driven via NXP PCA9554 I2C to GPIO muxer References: <877gchmggw.fsf@natisbad.org> <527ECC4C.8080207@gmail.com> Message-ID: <8738n2hfci.fsf@natisbad.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sebastian, Sebastian Hesselbarth writes: >> @@ -154,6 +161,30 @@ >> gpios = <&gpio2 0 1>; /* GPIO 64 Active Low */ >> linux,default-trigger = "keep"; >> }; >> + >> + sata1_led { >> + label = "rn104:blue:sata1"; >> + gpios = <&pca9554 0 1>; /* Active Low */ > > Same comment as for ReadyNAS 2120 patch: > > #include and use GPIO_ACTIVE_HIGH/LOW. Unlike RN2120 .dts for which I was able to change all the high/low values for macros in a single move, if I do the changes here for this specific patch, the .dts file for the RN104 will contain both values and macros. What about the following options?: - send a preliminary patch to change all the values for macros in RN104 .dts file once -rc1 is here and then resubmit the PCA9554 patch with macros? - have the patch applied as is and then convert the whole RN104 .dts w/ another patch. Anyway, once RN2120 is accepted, I intend to spend some time doing some housekeeping on other readynas .dts file based on the comments you made recently (macros, reg, addressing, phy info, etc), and also some minor points (whitespaces). Cheers, a+ From mboxrd@z Thu Jan 1 00:00:00 1970 From: arno-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org (Arnaud Ebalard) Subject: Re: [PATCH] ARM: mvebu: Add RN104 SATA LEDs driven via NXP PCA9554 I2C to GPIO muxer Date: Mon, 11 Nov 2013 21:07:41 +0100 Message-ID: <8738n2hfci.fsf@natisbad.org> References: <877gchmggw.fsf@natisbad.org> <527ECC4C.8080207@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Hesselbarth Cc: Jason Cooper , Andrew Lunn , Gregory Clement , Russell King , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Sebastian, Sebastian Hesselbarth writes: >> @@ -154,6 +161,30 @@ >> gpios = <&gpio2 0 1>; /* GPIO 64 Active Low */ >> linux,default-trigger = "keep"; >> }; >> + >> + sata1_led { >> + label = "rn104:blue:sata1"; >> + gpios = <&pca9554 0 1>; /* Active Low */ > > Same comment as for ReadyNAS 2120 patch: > > #include and use GPIO_ACTIVE_HIGH/LOW. Unlike RN2120 .dts for which I was able to change all the high/low values for macros in a single move, if I do the changes here for this specific patch, the .dts file for the RN104 will contain both values and macros. What about the following options?: - send a preliminary patch to change all the values for macros in RN104 .dts file once -rc1 is here and then resubmit the PCA9554 patch with macros? - have the patch applied as is and then convert the whole RN104 .dts w/ another patch. Anyway, once RN2120 is accepted, I intend to spend some time doing some housekeeping on other readynas .dts file based on the comments you made recently (macros, reg, addressing, phy info, etc), and also some minor points (whitespaces). Cheers, a+ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html