From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34742)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VQfj7-0000yq-Ia
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:49:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VQfj2-0004fJ-8B
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:49:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VQfj1-0004f2-Vq
	for qemu-devel@nongnu.org; Mon, 30 Sep 2013 11:49:32 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1380452123-5989-1-git-send-email-mst@redhat.com>
	<1380452123-5989-2-git-send-email-mst@redhat.com>
	<20130930151056.32699e7f@nial.usersys.redhat.com>
	<20130930144050.GB22806@redhat.com>
	<CAFEAcA8Q3EWwL=fKgaYP-eYXR5aVJ1iMkTT71D=nEPmm+0OOiQ@mail.gmail.com>
Date: Mon, 30 Sep 2013 17:49:26 +0200
In-Reply-To: <CAFEAcA8Q3EWwL=fKgaYP-eYXR5aVJ1iMkTT71D=nEPmm+0OOiQ@mail.gmail.com>
	(Peter Maydell's message of "Tue, 1 Oct 2013 00:10:52 +0900")
Message-ID: <8738om1f95.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 30 September 2013 23:40, Michael S. Tsirkin <mst@redhat.com> wrote:
>> diff --git a/include/qapi/error.h b/include/qapi/error.h
>> index 7d4c696..b85e996 100644
>> --- a/include/qapi/error.h
>> +++ b/include/qapi/error.h
>> @@ -13,14 +13,15 @@
>>  #define ERROR_H
>>
>>  #include "qemu/compiler.h"
>> +#include "qemu/typedefs.h"
>>  #include "qapi-types.h"
>>  #include <stdbool.h>
>>
>>  /**
>> - * A class representing internal errors within QEMU.  An error has a ErrorClass
>> + * Error:
>> + * An object representing internal errors within QEMU.  An error has a ErrorClass
>>   * code and a human message.
>>   */
>> -typedef struct Error Error;
>
> Does the process-doc-comments tool really cope with documentation comments
> that are completely separate from the typedef like this?

Even if they do, I don't.