From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3cnx-0002te-3L for qemu-devel@nongnu.org; Sun, 28 Jul 2013 22:03:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3cnw-0005el-1u for qemu-devel@nongnu.org; Sun, 28 Jul 2013 22:03:21 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:48550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3cnv-0005dm-Mz for qemu-devel@nongnu.org; Sun, 28 Jul 2013 22:03:19 -0400 From: Rusty Russell In-Reply-To: <87iozybonc.fsf@codemonkey.ws> References: <87li4v8ktz.fsf@rustcorp.com.au> <87ehan8hhn.fsf@rustcorp.com.au> <87ppu66a73.fsf@codemonkey.ws> <20130725145215.GA3758@redhat.com> <51F13C85.8050108@suse.de> <20130725152427.GH3758@redhat.com> <87iozybonc.fsf@codemonkey.ws> Date: Mon, 29 Jul 2013 09:25:20 +0930 Message-ID: <8738qy8ck7.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] vhost acceleration broken? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori , "Michael S. Tsirkin" , Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Peter Maydell , qemu-devel , Stefan Hajnoczi Anthony Liguori writes: > "Michael S. Tsirkin" writes: > >> On Thu, Jul 25, 2013 at 04:56:05PM +0200, Andreas F=C3=A4rber wrote: >>> Am 25.07.2013 16:52, schrieb Michael S. Tsirkin: >>> > On Thu, Jul 25, 2013 at 08:28:00AM -0500, Anthony Liguori wrote: >>> >> We have a pretty awful legacy command line set that comes from years= of >>> >> half-baked concepts and the years when too many people just committed >>> >> random shit to the tree. >>> >> >>> >> I think we probably need to start planning for a clean break. Maybe >>> >> that's a good target for a 2.0 version... >>> >=20 >>> > Assuming -netdev supports all required configurations, we should >>> > remove -net from the -help output. >>>=20 >>> Peter had raised the issue of -netdev not working well with boards that >>> already supply a default NIC - was there a solution yet? >>>=20 >>> Andreas >> >> Whoever is removing -net will have to code that up. Want to do this? > > I would not rush to remove things. If we're going to go through a > deprecation process, we should start with a proposal on what things > should be removed and go from there. > > I still don't even think -netdev is the right answer here either. > Wouldn't it make more sense to have something like: > > qemu -vnic tap,script=3D/foo/myscript > > Or something vaguely understandable by a human? OK. It seems to me that each net device has a host side and a guest side, which you can mix and match. So the commandline should reflect that explicitly: qemu -hostdev net,[tap|user|bridge|socket|vde],.... -guestdev net,= .... If you have a built-in net device on your emulated board, you've got one implied -guestdev net. And similar principles apply to other things like consoles and disks. Now, guest and host terms may suck. But please pick one terminology and use it *everywhere*. Documentation, code and cmdline. Thanks, Rusty.