All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Oliver Neukum <oliver@neukum.org>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	Enrico Mioso <mrkiko.rs@gmail.com>
Subject: Re: [PATCH] net: cdc_ether: allow combined control and data interface
Date: Fri, 28 Jun 2013 17:44:07 +0200	[thread overview]
Message-ID: <8738s21bqw.fsf@nemi.mork.no> (raw)
In-Reply-To: <1419214.UqpcbE98T1@linux-5eaq.site> (Oliver Neukum's message of "Fri, 28 Jun 2013 17:32:25 +0200")

Oliver Neukum <oliver@neukum.org> writes:

> On Friday 28 June 2013 17:17:08 Bjørn Mork wrote:
>> Some Icera based Huawei modems handled by this driver are not
>> completely CDC ECM compliant, using the same USB interface for both
>> control and data. The CDC functional descriptors include a Union
>> naming this interface as both master and slave, so it is supportable
>> by relaxing the descriptor parsing in case these interfaces are
>> identical.
>
> The disconnect handler is uselessly complex. Just return if the
> interfaces are identical. There's nothing to do in that case.

Right.  Thanks. Will post a new version cleaning that up.



Bjørn

      reply	other threads:[~2013-06-28 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-28 15:17 [PATCH] net: cdc_ether: allow combined control and data interface Bjørn Mork
2013-06-28 15:32 ` Oliver Neukum
2013-06-28 15:44   ` Bjørn Mork [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738s21bqw.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=linux-usb@vger.kernel.org \
    --cc=mrkiko.rs@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.