[ath9k-devel] [PATCH 3/3] ath10k: create debugfs interface to trigger fw crash

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

> This can be useful for testing.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

This is handy.

> +static ssize_t ath10k_read_simulate_fw_crash(struct file *file,
> +					     char __user *user_buf,
> +					     size_t count, loff_t *ppos)
> +{
> +	const char buf[] = "To simulate firmware crash write anything to this"
> +			   " file.\nThis will force firmware to report a crash"
> +			   " to the host system.\n";
> +	return simple_read_from_buffer(user_buf, count, ppos, buf, strlen(buf));
> +}

But I'm not sure if just writing something to the file is a good idea.
Should it have some sort of protection, for example that user needs to
write a keyword or something?

-- 
Kalle Valo