From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51259)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Ujc1z-0006f9-HP
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 17:11:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Ujc1y-0001cE-H2
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 17:11:07 -0400
Received: from e9.ny.us.ibm.com ([32.97.182.139]:42890)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1Ujc1y-0001c9-BV
	for qemu-devel@nongnu.org; Mon, 03 Jun 2013 17:11:06 -0400
Received: from /spool/local
	by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Mon, 3 Jun 2013 17:11:03 -0400
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 0036D38C8059
	for <qemu-devel@nongnu.org>; Mon,  3 Jun 2013 17:10:57 -0400 (EDT)
Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r53LAvG557278542
	for <qemu-devel@nongnu.org>; Mon, 3 Jun 2013 17:10:57 -0400
Received: from d01av05.pok.ibm.com (loopback [127.0.0.1])
	by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r53LAvpo027288
	for <qemu-devel@nongnu.org>; Mon, 3 Jun 2013 17:10:57 -0400
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <CAFEAcA9b0hfQiPtAMOXrtb5LVL8Cx5PRf-ZeABzVgfZBN0m8-w@mail.gmail.com>
References: <1370291992-29510-1-git-send-email-aliguori@us.ibm.com>
	<CAFEAcA9b0hfQiPtAMOXrtb5LVL8Cx5PRf-ZeABzVgfZBN0m8-w@mail.gmail.com>
Date: Mon, 03 Jun 2013 16:10:54 -0500
Message-ID: <8738syoq75.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 3 June 2013 21:39, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> It's not a GObject.
>>
>> Cc: Gerd Hoffman <kraxel@redhat.com>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>> ---
>>  ui/gtk.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index 8dc9041..3bc2842 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>> @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
>>                                          pixbuf, c->hot_x, c->hot_y);
>>      gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
>>      g_object_unref(pixbuf);
>> -    g_object_unref(cursor);
>> +    gdk_cursor_unref(cursor);
>
> Function name in subject doesn't match code change :-)

Doh, ack.

Regards,

Anthony Liguori

>
> -- PMM