All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-mmc@vger.kernel.org, jh80.chung@samsung.com,
	patches@linaro.org, tgih.jun@samsung.com
Subject: Re: [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static
Date: Tue, 12 Mar 2013 09:03:51 -0400	[thread overview]
Message-ID: <8738w0ixc8.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1361177589-23953-1-git-send-email-sachin.kamat@linaro.org> (Sachin Kamat's message of "Mon, 18 Feb 2013 14:23:08 +0530")

Hi,

On Mon, Feb 18 2013, Sachin Kamat wrote:
> Silences the following sparse warning:
> drivers/mmc/host/dw_mmc-exynos.c:218:5: warning:
> symbol 'dw_mci_exynos_probe' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/dw_mmc-exynos.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 72fd0f2..5a09c77 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -215,7 +215,7 @@ static const struct of_device_id dw_mci_exynos_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, dw_mci_exynos_match);
>  
> -int dw_mci_exynos_probe(struct platform_device *pdev)
> +static int dw_mci_exynos_probe(struct platform_device *pdev)
>  {
>  	const struct dw_mci_drv_data *drv_data;
>  	const struct of_device_id *match;

Thanks, pushed to mmc-next for 3.10.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2013-03-12 13:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18  8:53 [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static Sachin Kamat
2013-02-18  8:53 ` [PATCH 2/2] mmc: dw_mmc: exynos: Remove unnecessary use of of_match_ptr() Sachin Kamat
2013-03-13  4:32   ` Jaehoon Chung
2013-03-13 14:17   ` Seungwon Jeon
2013-03-13 15:35     ` Sachin Kamat
2013-03-20 15:31       ` Sachin Kamat
2013-03-22 16:54     ` Chris Ball
2013-02-18  9:41 ` [PATCH 1/2] mmc: dw_mmc: Make dw_mci_exynos_probe static Jaehoon Chung
2013-02-18 10:51   ` Seungwon Jeon
2013-03-04  4:36     ` Sachin Kamat
2013-03-12  9:22       ` Sachin Kamat
2013-03-12 13:03 ` Chris Ball [this message]
2013-03-12 14:52   ` Sachin Kamat
2013-03-12 15:00     ` Chris Ball
2013-03-12 15:04       ` Sachin Kamat
2013-03-13  4:20         ` Jaehoon Chung
2013-03-13  4:25           ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738w0ixc8.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=jh80.chung@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    --cc=tgih.jun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.