From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDdNj-0007Vp-RC for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:09:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDdNh-0005mT-Rb for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:09:23 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:58941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDdNh-0005m9-Aa for qemu-devel@nongnu.org; Thu, 07 Mar 2013 11:09:21 -0500 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Mar 2013 01:59:24 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 507912CE804A for ; Fri, 8 Mar 2013 03:09:12 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r27FuOr248431250 for ; Fri, 8 Mar 2013 02:56:25 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r27G9AlZ007005 for ; Fri, 8 Mar 2013 03:09:11 +1100 From: Anthony Liguori In-Reply-To: <87boavgzdo.fsf@blackfin.pond.sub.org> References: <1362418348-27398-1-git-send-email-pbonzini@redhat.com> <51350131.1070703@redhat.com> <874ngnsiig.fsf@blackfin.pond.sub.org> <87boavgzdo.fsf@blackfin.pond.sub.org> Date: Thu, 07 Mar 2013 10:09:06 -0600 Message-ID: <8738w719b1.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] sysbus: add no_user for devices using mmio or IRQ or GPIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Peter Maydell Cc: Paolo Bonzini , qemu-devel@nongnu.org Markus Armbruster writes: > Peter Maydell writes: >>>> [and I don't think "this device >>>> can be added via the monitor but not the command line" >>>> counts as consistent or coherent...] >>> >>> no_user applies equally to -device and device_add. >> >> In the codebase as it stands, it applies only to -device. >> I agree that we should be consistent here, which we could do >> by applying Christian's patch or some variation to make device_add >> honour no_user. (Or by removing no_user altogether :-)) > > Actually, it appears to apply only to help now! > > git-bisect blames this one: Let's step back and try to figure out the problem we're trying to solve. What is -devices help trying to show? Devices that are valid to for a user to pass? Hint: on a PC, the only thing that's valid to add are devices that implement a certain bus type. In fact, it depends on the bus model. So if you want to make -device help prettier, we should add a filter that looks at the busses available and filters anything that isn't an instance of the appropriate bus types. Regards, Anthony Liguori