All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>,
	linux-kernel@vger.kernel.org, jolsa@redhat.com,
	peterz@infradead.org, mingo@elte.hu
Subject: Re: [PATCH] perf report: fix handling of memory sampling sort orders
Date: Tue, 26 Feb 2013 14:46:14 +0900	[thread overview]
Message-ID: <8738wjtyop.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20130222184322.GF16956@infradead.org> (Arnaldo Carvalho de Melo's message of "Fri, 22 Feb 2013 15:43:22 -0300")

Hi,

On Fri, 22 Feb 2013 15:43:22 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 22, 2013 at 03:28:38PM +0100, Stephane Eranian escreveu:
>> 
>> When the memory sampling sort orders were used on perf.data
>> files without memory sampling data, it would crash perf. This
>> patch fixes this by  handling the lack of memory information
>> gracefully, printing N/A and formatting columns correctly
>> whenever necessary.

It'd be great if we could detect the perf.data contains memory sampling
data and then warn user about it and exit like I did for branch
sampling.  What do you think?

Thanks,
Namhyung

      reply	other threads:[~2013-02-26  5:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-22 14:28 [PATCH] perf report: fix handling of memory sampling sort orders Stephane Eranian
2013-02-22 18:43 ` Arnaldo Carvalho de Melo
2013-02-26  5:46   ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738wjtyop.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.