From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings) Date: Thu, 21 Feb 2013 17:07:29 +1030 Message-ID: <8738wqgok6.fsf@rustcorp.com.au> References: <1360669793-6921-1-git-send-email-sjur.brandeland@stericsson.com> <1360669793-6921-2-git-send-email-sjur.brandeland@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Ohad Ben-Cohen , Sjur =?utf-8?Q?Br=C3=A6ndeland?= Cc: Dmitry Tarnyagin , Sjur =?utf-8?Q?Br=C3=A6ndelan?= =?utf-8?Q?d?= , Linus Walleij , Ido Yariv , "linux-kernel@vger.kernel.org" , Erwan Yvin , virtualization , netdev@vger.kernel.org, "David S. Miller" List-Id: virtualization@lists.linuxfoundation.org T2hhZCBCZW4tQ29oZW4gPG9oYWRAd2l6ZXJ5LmNvbT4gd3JpdGVzOgo+IEhpIFNqdXIsCj4KPiBP biBUdWUsIEZlYiAxMiwgMjAxMyBhdCAxOjQ5IFBNLCAgPHNqdXIuYnJhbmRlbGFuZEBzdGVyaWNz c29uLmNvbT4gd3JvdGU6Cj4+IEZyb206IFNqdXIgQnLDpm5kZWxhbmQgPHNqdXIuYnJhbmRlbGFu ZEBzdGVyaWNzc29uLmNvbT4KPj4KPj4gQWRkIGZ1bmN0aW9ucyBmb3IgY3JlYXRpbmcsIGRlbGV0 aW5nIGFuZCBraWNraW5nIGhvc3Qtc2lkZSB2aXJ0aW8gcmluZ3MuCj4+Cj4+IFRoZSBob3N0IHJp bmcgaXMgbm90IGludGVncmF0ZWQgd2l0aCB2aXJ0aXF1ZXVlcyBhbmQgY2Fubm90IGJlIG1hbmFn ZWQKPj4gdGhyb3VnaCB2aXJ0aW8tY29uZmlnLgo+Cj4gSXMgdGhhdCBhbiBpbmhlcmVudCBkZXNp Z24vaXNzdWUgb2YgdnJpbmdoIG9yIGp1c3QgYSBkZXNjcmlwdGlvbiBvZgo+IHRoZSBjdXJyZW50 IHZyaW5naCBjb2RlID8KCkl0J3MgYnkgZGVzaWduLiAgVGhlIHByb2R1Y2VyICh2aXJ0cXVldWUp IGFuZCBjb25zdW1lciAodnJpbmdoKSBhcmUgdHdvCnNpZGVzIG9mIHRoZSBzYW1lIGNvaW4sIGJ1 dCB0aGV5IGRvIGRpZmZlcmVudCB0aGluZ3MuCgp2aXJ0cXVldWUgaXMgYSBzbGlnaHRseSBoaWdo ZXIgbGV2ZWwgYWJzdHJhY3Rpb24gd2hpY2ggYXNzdW1lcyBhCnZpcnRpb19kZXZpY2UsIGJlY2F1 c2UgZXZlcnkgdXNlciBzbyBmYXIgaGFzIGhhZCBvbmUuICB2cmluZ2ggZG9lc24ndCwKYmVjYXVz ZSBpdCdzIGFsc28gYWltZWQgdG8gdW5kZXJsaWUgdmhvc3QuYyB3aGljaCBkb2Vzbid0IHJlYWxs eSBoYXZlCm9uZS4KCj4gVGhpcyBpcyBwb3NzaWJsZSBvZiBjb3Vyc2UgdGhhbmtzIHRvIHRoZSBh YnN0cmFjdGlvbiBwcm92aWRlZCBieQo+IHZpcnRpbzogcmVtb3RlcHJvYyBvbmx5IGltcGxlbWVu dHMgYSBzZXQgb2YgY2FsbGJhY2tzIHdoaWNoIHZpcnRpbwo+IGludm9rZXMgd2hlbiBuZWVkZWQu Cj4KPiBEbyB3ZSBub3Qgd2FudCB0byBmb2xsb3cgYSBzaW1pbGFyIGRlc2lnbiBzY2hlbWUgd2l0 aCB2cmluZ2ggPwoKSG1tLi4uIEkgY2xlYXJseSBqdW1wZWQgdGhlIGd1biwgYXNzdW1pbmcgY29u c2Vuc3VzIHdhcyBhbHJlYWR5IHJlYWNoZWQuCkkgaGF2ZSBwdXQgdGhlc2UgcGF0Y2hlcyAqYmFj ayogaW50byBwZW5kaW5nLXJlYmFzZXMsIGFuZCB0aGV5IHdpbGwgbm90CmJlIG1lcmdlZCB0aGlz IG1lcmdlIHdpbmRvdy4KCkNoZWVycywKUnVzdHkuCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752656Ab3BUG4F (ORCPT ); Thu, 21 Feb 2013 01:56:05 -0500 Received: from ozlabs.org ([203.10.76.45]:40175 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584Ab3BUG4D convert rfc822-to-8bit (ORCPT ); Thu, 21 Feb 2013 01:56:03 -0500 From: Rusty Russell To: Ohad Ben-Cohen , Sjur =?utf-8?Q?Br=C3=A6ndeland?= Cc: "David S. Miller" , Sjur =?utf-8?Q?Br=C3=A6ndelan?= =?utf-8?Q?d?= , netdev@vger.kernel.org, virtualization , "linux-kernel\@vger.kernel.org" , Dmitry Tarnyagin , Linus Walleij , Erwan Yvin , Ido Yariv Subject: Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings) In-Reply-To: References: <1360669793-6921-1-git-send-email-sjur.brandeland@stericsson.com> <1360669793-6921-2-git-send-email-sjur.brandeland@stericsson.com> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Thu, 21 Feb 2013 17:07:29 +1030 Message-ID: <8738wqgok6.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ohad Ben-Cohen writes: > Hi Sjur, > > On Tue, Feb 12, 2013 at 1:49 PM, wrote: >> From: Sjur Brændeland >> >> Add functions for creating, deleting and kicking host-side virtio rings. >> >> The host ring is not integrated with virtiqueues and cannot be managed >> through virtio-config. > > Is that an inherent design/issue of vringh or just a description of > the current vringh code ? It's by design. The producer (virtqueue) and consumer (vringh) are two sides of the same coin, but they do different things. virtqueue is a slightly higher level abstraction which assumes a virtio_device, because every user so far has had one. vringh doesn't, because it's also aimed to underlie vhost.c which doesn't really have one. > This is possible of course thanks to the abstraction provided by > virtio: remoteproc only implements a set of callbacks which virtio > invokes when needed. > > Do we not want to follow a similar design scheme with vringh ? Hmm... I clearly jumped the gun, assuming consensus was already reached. I have put these patches *back* into pending-rebases, and they will not be merged this merge window. Cheers, Rusty.