All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: mdroth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open()
Date: Mon, 14 Jan 2013 23:25:58 +0100	[thread overview]
Message-ID: <8738y3mmfd.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20130111174740.GM1543@vm> (mdroth@linux.vnet.ibm.com's message of "Fri, 11 Jan 2013 11:47:40 -0600")

mdroth <mdroth@linux.vnet.ibm.com> writes:

> On Fri, Jan 11, 2013 at 11:25:02AM +0100, Markus Armbruster wrote:
>> We detect errors in seven places.  One reports with g_error(), which
>
> Do you mean "in several places"? I can fix this in tree.

I counted seven places, but it doesn't really matter, "several" would be
fine, too.

>> calls abort(), the others report with g_critical().  Three of them
>> exit(), three return false.
>> 
>> Always report with g_critical(), and return false.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

Thanks!

  reply	other threads:[~2013-01-14 22:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 10:24 [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups Markus Armbruster
2013-01-11 10:24 ` [Qemu-devel] [PATCH 1/6] qemu-ga: Document intentional fall through in channel_event_cb() Markus Armbruster
2013-01-11 17:39   ` mdroth
2013-01-11 10:24 ` [Qemu-devel] [PATCH 2/6] qemu-ga: Drop pointless lseek() from ga_open_pidfile() Markus Armbruster
2013-01-11 17:41   ` mdroth
2013-01-11 10:24 ` [Qemu-devel] [PATCH 3/6] qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path Markus Armbruster
2013-01-11 17:42   ` mdroth
2013-01-11 10:25 ` [Qemu-devel] [PATCH 4/6] qemu-ga: Plug fd leak on ga_channel_listen_accept() " Markus Armbruster
2013-01-11 17:44   ` mdroth
2013-01-11 10:25 ` [Qemu-devel] [PATCH 5/6] qemu-ga: Plug fd leak on ga_channel_open() error paths Markus Armbruster
2013-01-11 17:44   ` mdroth
2013-01-11 10:25 ` [Qemu-devel] [PATCH 6/6] qemu-ga: Handle errors uniformely in ga_channel_open() Markus Armbruster
2013-01-11 17:47   ` mdroth
2013-01-14 22:25     ` Markus Armbruster [this message]
2013-01-11 16:07 ` [Qemu-devel] [PATCH 0/6] Simple qemu-ga fixes and cleanups Eric Blake
2013-01-14 16:26 ` Luiz Capitulino
2013-01-14 19:45 ` mdroth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738y3mmfd.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.