Re: [PATCH] netfilter: xt_LOG: avoid using old-style "<.>" printk prefix

[Romain Francoise <romain@orebokech.com>]

Hi Pablo,

Pablo Neira Ayuso <pablo@netfilter.org> writes:

> ebt_log chunk is missing.

Sorry, didn't notice that it has the same bug. Do you want that in the
same patch, or separate?

>>  	m->buf[m->count] = 0;
>> -	printk("%s\n", m->buf);
>> +	printk_emit(0, level, NULL, 0, "%s\n", m->buf);

> I think it should be printk_emit(-1, ... Note facility is -1.

> Thus, we skip the syslog prefix stripping (we can skip it and save
> some cycles).

I don't think that's possible, the facility is copied down to user-space
consumers and it has to be zero for the message to be identified as
originating from the kernel (0 is LOG_KERN).

As it boils down to a single test for KERN_SOH_ASCII I don't think it
matters very much.

Thanks!