All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: IAN CHEN <ian.cy.chen@samsung.com>
Cc: linkinjeon@gmail.com, adrian.hunter@intel.com,
	subhashj@codeaurora.org, linus.walleij@linaro.org,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	d.j.shin@samsung.com, jongtae22.kim@samsung.com,
	kyungmin.park@samsung.com, jh80.chung@samsung.com
Subject: Re: [PATCH v6] mmc: card: Skip secure option for MoviNAND.
Date: Wed, 29 Aug 2012 06:26:59 -0400	[thread overview]
Message-ID: <873936vvrg.fsf@octavius.laptop.org> (raw)
In-Reply-To: <503DB130.8090807@samsung.com> (IAN CHEN's message of "Wed, 29 Aug 2012 15:05:36 +0900")

Hi,

On Wed, Aug 29 2012, IAN CHEN wrote:
> For several MoviNAND, there are some known issue with secure option.
> For these specific MoviNAND device, we skip secure option.
>
> You could refer this discussion in XDA developers.
> http://forum.xda-developers.com/showthread.php?t=1644364
> https://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB
>
> Signed-off-by: Ian Chen <ian.cy.chen@samsung.com>
> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
> Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks.  We should explain the nature of the bug in the commit message,
so that users and the stable@ maintainers know how bad the problem is
by reading the patch.  (This should go to stable@, right?  Do you know
which kernel versions are affected?)

I'll add something like this, unless you have a better proposal:

==
For several MoviNAND, there are some known issues with secure option.
For these specific MoviNAND device, we skip secure option.

Specifically, there is a bug in the eMMC firmware that causes 
unrecoverable corruption when the MMC is erased with MMC_CAP_ERASE
enabled.

You could refer this discussion in XDA developers.
http://forum.xda-developers.com/showthread.php?t=1644364
https://plus.google.com/111398485184813224730/posts/21pTYfTsCkB#111398485184813224730/posts/21pTYfTsCkB
==

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2012-08-29 10:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29  6:05 [PATCH v6] mmc: card: Skip secure option for MoviNAND IAN CHEN
2012-08-29  7:27 ` Jaehoon Chung
2012-08-29 10:26 ` Chris Ball [this message]
2012-08-30  1:36   ` IAN CHEN
2012-08-30  1:52     ` Chris Ball
  -- strict thread matches above, loose matches on Subject: below --
2012-08-29  5:04 IAN CHEN
2012-08-29  5:36 ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873936vvrg.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=adrian.hunter@intel.com \
    --cc=d.j.shin@samsung.com \
    --cc=ian.cy.chen@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=jongtae22.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linkinjeon@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=subhashj@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.