From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: dt: Add 'broken-cd' DT binding Date: Wed, 22 Aug 2012 10:54:36 -0400 Message-ID: <87393f3rkj.fsf@octavius.laptop.org> References: <1345547371-6784-1-git-send-email-thomas.abraham@linaro.org> <87k3ws5uhs.fsf@octavius.laptop.org> <201208211208.49987.arnd@arndb.de> <87393g5mic.fsf@octavius.laptop.org> <5033A34E.7040201@gmail.com> <87pq6k46jg.fsf@octavius.laptop.org> <5033B0F0.7050506@gmail.com> <20120822055151.GT24242@S2101-09.ap.freescale.net> <877gsr5iz1.fsf@octavius.laptop.org> <87y5l7421h.fsf@octavius.laptop.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Thomas Abraham's message of "Wed, 22 Aug 2012 17:34:53 +0530") Sender: linux-samsung-soc-owner@vger.kernel.org To: Thomas Abraham Cc: Shawn Guo , Rob Herring , Arnd Bergmann , linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, grant.likely@secretlab.ca, patches@linaro.org, Wolfram Sang List-Id: linux-mmc@vger.kernel.org Hi Thomas, On Wed, Aug 22 2012, Thomas Abraham wrote: >> none -> currently "samsung,sdhci-cd-internal" >> broken-cd -> currently "samsung,sdhci-cd-none" >> cd-gpios -> currently "samsung,sdhci-cd-gpios" >> non-removable -> currently "samsung,sdhci-cd-permanent" >> cd-gpios + samsung,sdhci-cd-external -> currently "samsung,sdhci-cd-external" >> >> How does that sound? > > Not quite there yet. It is not possible to leave out cd-gpios for > "samsung,sdhci-cd-internal" since the current Samsung pinmux > configuration piggybacks on gpio dt binding. Can we use the following > instead. > > none -> currently "samsung,sdhci-cd-none" > broken-cd -> currently "samsung,sdhci-cd-none" > cd-gpios -> currently "samsung,sdhci-cd-gpios" > non-removable -> currently "samsung,sdhci-cd-permanent" > cd-gpios + samsung,sdhci-cd-internal -> currently "samsung,sdhci-cd-internal" I see. Okay; unless anyone has better ideas, it sounds like you should go ahead and do that -- with something like this in your binding docs: "This binding differs from the core MMC binding by requiring a cd-gpios property to be present to use internal card-detection. If no cd-gpios are present (and "non-removable" is missing) the driver will poll for card-detection as if a "broken-cd" property was provided." I'll send out the new core bindings doc shortly. Finishing off another thread -- the "samsung-sdhci.txt" name is okay. Thanks, - Chris. -- Chris Ball One Laptop Per Child