From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1T0ux9-0005Hx-IS
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 09:45:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1T0ux5-0003iL-8S
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 09:45:07 -0400
Received: from e3.ny.us.ibm.com ([32.97.182.143]:34874)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1T0ux5-0003gx-4O
	for qemu-devel@nongnu.org; Mon, 13 Aug 2012 09:45:03 -0400
Received: from /spool/local
	by e3.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Mon, 13 Aug 2012 09:44:59 -0400
Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235])
	by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 557096E805C
	for <qemu-devel@nongnu.org>; Mon, 13 Aug 2012 09:44:36 -0400 (EDT)
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q7DDiZ1u103552
	for <qemu-devel@nongnu.org>; Mon, 13 Aug 2012 09:44:35 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q7DDiZ2h009892
	for <qemu-devel@nongnu.org>; Mon, 13 Aug 2012 09:44:35 -0400
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <CAFEAcA_d9SELeuDf_OAjdZPSgz1_MdpYVYoXE76mMMoWnTyu0A@mail.gmail.com>
References: <1344614655-2195-1-git-send-email-aliguori@us.ibm.com>
	<1344614655-2195-5-git-send-email-aliguori@us.ibm.com>
	<CAFEAcA_d9SELeuDf_OAjdZPSgz1_MdpYVYoXE76mMMoWnTyu0A@mail.gmail.com>
Date: Mon, 13 Aug 2012 08:44:29 -0500
Message-ID: <87393qhpoi.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak
	symbols
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 10 August 2012 17:04, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> This lets us provide a default implementation of a symbol which targets can
>> override.
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> I'm sure you'll be thrilled to hear that this doesn't seem to break MacOS
> builds :-)

Thank you for testing it.  I neglected to mention that I did a fair bit
of investigation before hand and was able to confirm that all platforms
we care about (Windows, Linux/Unix, OS X) and all compilers we care
about (GCC, LLVM) support weak symbols.

There may be different attribute names across compilers--it wasn't very
clear to me, but they definitely all have the feature in some form.

Regards,

Anthony Liguori

>
> -- PMM