From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wGk-000417-WF for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:09:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0wGf-0000xr-4P for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:09:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0wGe-0000xn-SM for qemu-devel@nongnu.org; Mon, 13 Aug 2012 11:09:21 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DF9JEO006306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 11:09:20 -0400 From: Juan Quintela In-Reply-To: <50291634.1060407@redhat.com> (Eric Blake's message of "Mon, 13 Aug 2012 08:59:00 -0600") References: <1344855057-32509-1-git-send-email-quintela@redhat.com> <50291634.1060407@redhat.com> Date: Mon, 13 Aug 2012 17:08:22 +0200 Message-ID: <87393qygm1.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [RFC 0/7] Migration stats Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Eric Blake wrote: > On 08/13/2012 04:50 AM, Juan Quintela wrote: >> Hi >> >> This modifies the output of info migrate/qmp_query_migrate to add the >> stats that I got request for. >> >> - It moves total time to MigrationInfo instead of ram (luiz suggestion) > > Now's the time to do this, since the stat is new to 1.2 and we haven't > yet made a release with it. > > Should we also rename 'MigrationInfo' to 'MigrationRamInfo', so that we > don't make a similar mistake in the future of putting a stat in the > wrong category? Luiz? I dont' care one way or the other O:-) >> What do I want to know: >> >> - is there any stat that you want? Once here, adding a new one should >> be easy. > > Should we have some sort of stat for the number of pages that are sent > more than once, and/or for the maximum count of times that a given page > was sent? Having hot/cold page analysis might make it easier to decide > in the future which pages to avoid sending until the very end, and > knowing how many pages are sent multiple times as well as the maximum > times any one page is sent might help. That is not trivial to do without "duplicating" the bitmap. Bitmap is already quite big on machines with huge memory. Adding a field to show how many times a page have been sent sounds too much. Furthermore, how could this information could be used externally. >> >> - examples are not done, waiting until people agree with what params >> are needed. > > Fair enough for RFC purposes. > >> >> - luiz added in case he has QMP commets. >> >> - erik added for libvirt comments. > > Eric, actually. Sorry :p Later, Juan.