From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swb4Z-0007Ze-0S for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:42:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swb4Y-0002aA-29 for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:42:54 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:48397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swb4X-0002Zy-Tl for qemu-devel@nongnu.org; Wed, 01 Aug 2012 11:42:53 -0400 Received: by yenl1 with SMTP id l1so7235976yen.4 for ; Wed, 01 Aug 2012 08:42:53 -0700 (PDT) From: Anthony Liguori In-Reply-To: References: Date: Wed, 01 Aug 2012 10:42:50 -0500 Message-ID: <873946mxdx.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] fix Xen compilation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, Ian Campbell , fantonifabio@tiscali.it, Stefano Stabellini Stefano Stabellini writes: > xen_pt_unregister_device is used as PCIUnregisterFunc, so it should > match the type. > > Signed-off-by: Stefano Stabellini Applied. Thanks. Regards, Anthony Liguori > > diff --git a/hw/xen_pt.c b/hw/xen_pt.c > index fdf68aa..307119a 100644 > --- a/hw/xen_pt.c > +++ b/hw/xen_pt.c > @@ -764,7 +764,7 @@ out: > return 0; > } > > -static int xen_pt_unregister_device(PCIDevice *d) > +static void xen_pt_unregister_device(PCIDevice *d) > { > XenPCIPassthroughState *s = DO_UPCAST(XenPCIPassthroughState, dev, d); > uint8_t machine_irq = s->machine_irq; > @@ -814,8 +814,6 @@ static int xen_pt_unregister_device(PCIDevice *d) > memory_listener_unregister(&s->memory_listener); > > xen_host_pci_device_put(&s->real_device); > - > - return 0; > } > > static Property xen_pci_passthrough_properties[] = { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] fix Xen compilation Date: Wed, 01 Aug 2012 10:42:50 -0500 Message-ID: <873946mxdx.fsf@codemonkey.ws> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini , qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, Ian Campbell , fantonifabio@tiscali.it, Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Stefano Stabellini writes: > xen_pt_unregister_device is used as PCIUnregisterFunc, so it should > match the type. > > Signed-off-by: Stefano Stabellini Applied. Thanks. Regards, Anthony Liguori > > diff --git a/hw/xen_pt.c b/hw/xen_pt.c > index fdf68aa..307119a 100644 > --- a/hw/xen_pt.c > +++ b/hw/xen_pt.c > @@ -764,7 +764,7 @@ out: > return 0; > } > > -static int xen_pt_unregister_device(PCIDevice *d) > +static void xen_pt_unregister_device(PCIDevice *d) > { > XenPCIPassthroughState *s = DO_UPCAST(XenPCIPassthroughState, dev, d); > uint8_t machine_irq = s->machine_irq; > @@ -814,8 +814,6 @@ static int xen_pt_unregister_device(PCIDevice *d) > memory_listener_unregister(&s->memory_listener); > > xen_host_pci_device_put(&s->real_device); > - > - return 0; > } > > static Property xen_pci_passthrough_properties[] = {