All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add libapr-package
Date: Tue, 17 Apr 2012 14:01:29 +0200	[thread overview]
Message-ID: <873982lg86.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20120417133932.4552d886@skate> (Thomas Petazzoni's message of "Tue, 17 Apr 2012 13:39:32 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> +	bool "libapr"
 >> +	help
 >> +	  The mission of the Apache Portable Runtime (APR) project is to create and maintain software libraries that provide a predictable and consistent interface to underlying platform-specific implementations

 Thomas> This text should be wrapped at ~80 columns.

And the upstream URL should be added below.

 >> new file mode 100644
 >> index 0000000..57da8ef
 >> --- /dev/null
 >> +++ b/package/libapr/libapr.mk
 >> @@ -0,0 +1,12 @@
 >> +#############################################################
 >> +#
 >> +# libapr
 >> +#
 >> +#############################################################
 >> +LIBAPR_VERSION = 1.4.6
 >> +LIBAPR_SOURCE = apr-$(LIBAPR_VERSION).tar.gz

 Thomas> Yegor's suggestion didn't work because by default we download
 Thomas> <package-name>-<package-version>.tar.gz. However here you decided to
 Thomas> name the Buildroot package "libapr", while the upstream package is
 Thomas> "apr". Maybe we should use the "apr" name like upstream?

Agreed.

 >> +LIBAPR_SITE = http://mirror.switch.ch/mirror/apache/dist/apr

I know the apr website directs you to a local mirror, but perhaps it
would make more sense to use archive.apache.org/dist/apr instead of this
.ch mirror?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-04-17 12:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Re:[PATCH] Add libapr-package>
2012-04-17 10:59 ` [Buildroot] [PATCH v2] Add libapr-package Rico Bachmann
2012-04-17 10:59 ` [Buildroot] [PATCH] " Rico Bachmann
2012-04-17 11:36   ` Maxime Ripard
2012-04-17 12:18     ` Rico Bachmann
2012-04-17 11:39   ` Thomas Petazzoni
2012-04-17 12:01     ` Peter Korsgaard [this message]
2012-04-17 12:22       ` Rico Bachmann
2012-04-17 12:18     ` Rico Bachmann
2012-04-17 14:35 Rico Bachmann
2012-04-21 12:58 ` Arnout Vandecappelle
2012-04-24  9:32   ` Rico Bachmann
2012-04-27 19:21     ` Arnout Vandecappelle
  -- strict thread matches above, loose matches on Subject: below --
2012-04-17 13:16 Rico Bachmann
2012-04-17 13:20 ` Baruch Siach
2012-04-17 13:26   ` Rico Bachmann
2012-04-17 13:29     ` Baruch Siach
2012-04-17 13:22 ` Yegor Yefremov
2012-04-17 13:29   ` Rico Bachmann
2012-04-17 13:25 ` Maxime Ripard
2012-04-17 13:35   ` Rico Bachmann
2012-04-17 10:05 Rico Bachmann
2012-04-17 10:20 ` Yegor Yefremov
2012-04-17 10:25 ` Yegor Yefremov
2012-04-17 10:31   ` Rico Bachmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873982lg86.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.