From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH][just nitpicking :)] Make vgscan behaviour consistent with pvscan
Date: Mon, 26 Mar 2012 14:06:46 +0200 [thread overview]
Message-ID: <87398vsh0p.fsf@mornfall.net> (raw)
In-Reply-To: <4F6B1F13.5080103@redhat.com> (Peter Rajnoha's message of "Thu, 22 Mar 2012 13:46:11 +0100")
Hi,
Peter Rajnoha <prajnoha@redhat.com> writes:
> Just this minor thing... Are you OK with this?
>
> If using "--cache" opt, we directly scan and update lvmetad if running.
> If not using "--cache" opt, we get the info from lvmetad if running.
yes, I think this is good for UI consistency. One thing to watch out for
though is on-disk metadata inconsistencies. Before the patch, any
"vgscan" would notice those, but afterwards, only "vgscan --cache" can
be used to detect bad on-disk metadata.
We could also want to extend pvscan --cache to report (and maybe fix?)
any metadata inconsistencies it may find.
[snip; patch looks OK]
Petr
--
id' Ash = Ash; id' Dust = Dust; id' _ = undefined
parent reply other threads:[~2012-03-26 12:06 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4F6B1F13.5080103@redhat.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87398vsh0p.fsf@mornfall.net \
--to=prockai@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.