From: Chris Ball <cjb@laptop.org>
To: Ido Yariv <ido@wizery.com>
Cc: Sekhar Nori <nsekhar@ti.com>,
linux-mmc@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH REPOST 1/2] mmc: davinci: Eliminate spurious interrupts
Date: Thu, 15 Mar 2012 23:32:42 -0400 [thread overview]
Message-ID: <873999cjad.fsf@laptop.org> (raw)
In-Reply-To: <1331501999-13144-1-git-send-email-ido@wizery.com> (Ido Yariv's message of "Sun, 11 Mar 2012 23:39:58 +0200")
Hi,
On Sun, Mar 11 2012, Ido Yariv wrote:
> The davinci mmc interrupt handler fills the fifo, as long as the DXRDY
> or DRRDY bits are set in the status register.
>
> If interrupts fire during this loop, they will be handled by the
> handler, but the interrupt controller will still buffer these. As a
> result, the handler will be called again to serve these needlessly. In
> order to avoid these spurious interrupts, keep interrupts masked while
> filling the fifo.
>
> Signed-off-by: Ido Yariv <ido@wizery.com>
> Tested-by: Rajashekhara, Sudhakar <sudhakar.raj@ti.com>
Thanks, I've pushed both of these two patches to mmc-next for 3.4 now.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-03-16 3:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4F1E9194.90608@mvista.com>
2012-01-24 11:16 ` [RFC 1/2] mmc: davinci: Eliminate spurious interrupts Ido Yariv
2012-01-24 11:16 ` [RFC 2/2] mmc: davinci: Poll status for small size transfers Ido Yariv
2012-01-27 8:11 ` [RFC 1/2] mmc: davinci: Eliminate spurious interrupts Rajashekhara, Sudhakar
2012-01-29 19:37 ` Ido Yariv
[not found] ` <1327403766-962-1-git-send-email-ido-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2012-01-31 11:30 ` Rajashekhara, Sudhakar
2012-03-11 21:39 ` [PATCH REPOST " Ido Yariv
2012-03-11 21:39 ` [PATCH REPOST 2/2] mmc: davinci: Poll status for small size transfers Ido Yariv
2012-03-16 3:32 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873999cjad.fsf@laptop.org \
--to=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=ido@wizery.com \
--cc=linux-mmc@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.