From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH V2 3/8] drivers/mtd: transfer NAND notions to MTD core
Date: Mon, 19 Dec 2011 11:48:49 +0100 [thread overview]
Message-ID: <8739cgg7la.fsf@free.fr> (raw)
In-Reply-To: <20111219094932.GC27267@pengutronix.de> (Sascha Hauer's message of "Mon, 19 Dec 2011 10:49:32 +0100")
Sascha Hauer <s.hauer@pengutronix.de> writes:
> On Fri, Dec 16, 2011 at 10:50:29PM +0100, Robert Jarzmik wrote:
>
>>
>> if MTD
>>
>> +config MTD_WRITE
>> + bool
>> + default y
>> + prompt "Support writing to MTD devices"
>> +
>> +config MTD_READ_OOB
>> + bool
>> + default y
>> + prompt "Create a device for reading the OOB data"
>> +
>
> This one is a rename...
>
>>
>> -config NAND_READ_OOB
>> - bool
>> - default y
>> - prompt "create a device for reading the OOB data"
>> -
>
> from this one, but not all references to it were renamed.
Arg. I see it now. I'll amend this patch.
> This revealed a bug which was present before this patch. The following
> fixes this, see the commit log for more details. Can you rebase your
> series on this patch?
Of course.
> Otherwise your series seems to work properly.
Ok, great. Do you want me to resend the whole serie, or provide you a pull
request with this patchset rebased on barebox.git/next, and your patch, and then
this serie ?
FWIW, I checked erase/read/write on mtdraw and mtd, and with the docg3
everything works fine. If I understand correctly, you tested with a NAND you've
got, which is great as a non-regression test :)
Cheers.
--
Robert
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-12-19 10:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 21:50 [PATCH V2 0/8] mtd framework rework Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 1/8] drivers/mtd: move nand.c into core.c Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 2/8] drivers/mtd: cosmetic changes Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 3/8] drivers/mtd: transfer NAND notions to MTD core Robert Jarzmik
2011-12-19 9:49 ` Sascha Hauer
2011-12-19 10:48 ` Robert Jarzmik [this message]
2011-12-19 11:08 ` Sascha Hauer
2011-12-16 21:50 ` [PATCH V2 4/8] drivers/mtd: recover NAND default device name "nand" Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 5/8] drivers/mtd: fix core multiple MTD registrations Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 6/8] drivers/mtd: add mtd core hooks Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 7/8] mtd/drivers: split mtd mtdoob devices Robert Jarzmik
2011-12-19 9:50 ` Sascha Hauer
2011-12-19 10:50 ` Robert Jarzmik
2011-12-16 21:50 ` [PATCH V2 8/8] drivers/mtd: add the mtdraw device (data+oob) Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739cgg7la.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.