diff for duplicates of <8739ewk3m0.fsf@ti.com> diff --git a/a/1.txt b/N1/1.txt index f9234a3..78cae3d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,16 +15,16 @@ Govindraj <govindraj.ti@gmail.com> writes: >>>>> >>>>> Signed-off-by: Govindraj.R <govindraj.raja@ti.com> >>>> ->>>> Now that the driver is using runtime PM. Why do we still need +>>>> Now that the driver is using runtime PM. ?Why do we still need >>>> HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET? >>>> >>>> The comment in the code says: >>>> ->>>> /* ->>>> * During UART early init, device need to be probed ->>>> * to determine SoC specific init before omap_device ->>>> * is ready. Therefore, don't allow idle here ->>>> */ +>>>> ? ? ? ? ? ? ? ?/* +>>>> ? ? ? ? ? ? ? ? * During UART early init, device need to be probed +>>>> ? ? ? ? ? ? ? ? * to determine SoC specific init before omap_device +>>>> ? ? ? ? ? ? ? ? * is ready. ?Therefore, don't allow idle here +>>>> ? ? ? ? ? ? ? ? */ >>>> >>>> This was true when using the 8250 driver because it was not using >>>> runtime PM so could not know how to (re)enable the device. @@ -37,20 +37,20 @@ Govindraj <govindraj.ti@gmail.com> writes: >>> Forgot to add, this is still needed for >>> earlyprintk(CONFIG_EARLY_PRINTK) use case, >> ->> Ah, right. I forgot about that. Please update the changelog (and +>> Ah, right. ?I forgot about that. ?Please update the changelog (and >> comment in the code) to reflect that. >> >>> The initial boot prints until a console driver is available is from >>> "arch/arm/kernel/early_printk.c" which does a tx on uart console >>> and relies on configuration from bootloader. >>> ->>> during bootup earlyprink does a tx on uart console and if uart driver +>>> during bootup earlyprink does a tx on uart console and if ?uart driver >>> is not available yet >>> uart reset or idle done by hwmod layer can cause boot failures. >>> >>> --> put_char from earlyprintk.c ->>> --> reset/idle from hwmod layer ->>> --> put_char from earlyprintk.c +>>> ? ? ?--> reset/idle from hwmod layer +>>> ? ? ? ? ? --> put_char from earlyprintk.c >>> >>> >>> So console_uart reset or clock gating must be done only after uart @@ -111,7 +111,3 @@ used before it was loaded. This needs to be handled in device init code as it is today. Kevin --- -To unsubscribe from this list: send the line "unsubscribe linux-omap" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 191952c..8a9c0d8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,19 +4,10 @@ "ref\0CAAL8m4xmGQaQZm5Oz8B5e6Mt7VP7c_VwQ=AnfpKotZRci32JiQ@mail.gmail.com\0" "ref\0871uuhn4kw.fsf@ti.com\0" "ref\0CAAL8m4wzT-ecmVeU--EQGF1PxuZuB6WZj54MmVAk-kCtFUcUSg@mail.gmail.com\0" - "From\0Kevin Hilman <khilman@ti.com>\0" - "Subject\0Re: [PATCH v6 15/16] OMAP2+: UART: Enable back uart clocks with runtime API for early console\0" + "From\0khilman@ti.com (Kevin Hilman)\0" + "Subject\0[PATCH v6 15/16] OMAP2+: UART: Enable back uart clocks with runtime API for early console\0" "Date\0Thu, 13 Oct 2011 14:01:43 -0700\0" - "To\0Govindraj <govindraj.ti@gmail.com>\0" - "Cc\0Govindraj.R <govindraj.raja@ti.com>" - linux-omap@vger.kernel.org - linux-serial@vger.kernel.org - linux-arm-kernel@lists.infradead.org - Tony Lindgren <tony@atomide.com> - Partha Basak <p-basak2@ti.com> - Vishwanath Sripathy <vishwanath.bs@ti.com> - Rajendra Nayak <rnayak@ti.com> - " Santosh Shilimkar <santosh.shilimkar@ti.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Govindraj <govindraj.ti@gmail.com> writes:\n" @@ -36,16 +27,16 @@ ">>>>>\n" ">>>>> Signed-off-by: Govindraj.R <govindraj.raja@ti.com>\n" ">>>>\n" - ">>>> Now that the driver is using runtime PM. \302\240Why do we still need\n" + ">>>> Now that the driver is using runtime PM. ?Why do we still need\n" ">>>> HWMOD_INIT_NO_IDLE and HWMOD_INIT_NO_RESET?\n" ">>>>\n" ">>>> The comment in the code says:\n" ">>>>\n" - ">>>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240/*\n" - ">>>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * During UART early init, device need to be probed\n" - ">>>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * to determine SoC specific init before omap_device\n" - ">>>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 * is ready. \302\240Therefore, don't allow idle here\n" - ">>>> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 */\n" + ">>>> ? ? ? ? ? ? ? ?/*\n" + ">>>> ? ? ? ? ? ? ? ? * During UART early init, device need to be probed\n" + ">>>> ? ? ? ? ? ? ? ? * to determine SoC specific init before omap_device\n" + ">>>> ? ? ? ? ? ? ? ? * is ready. ?Therefore, don't allow idle here\n" + ">>>> ? ? ? ? ? ? ? ? */\n" ">>>>\n" ">>>> This was true when using the 8250 driver because it was not using\n" ">>>> runtime PM so could not know how to (re)enable the device.\n" @@ -58,20 +49,20 @@ ">>> Forgot to add, this is still needed for\n" ">>> earlyprintk(CONFIG_EARLY_PRINTK) use case,\n" ">>\n" - ">> Ah, right. \302\240I forgot about that. \302\240Please update the changelog (and\n" + ">> Ah, right. ?I forgot about that. ?Please update the changelog (and\n" ">> comment in the code) to reflect that.\n" ">>\n" ">>> The initial boot prints until a console driver is available is from\n" ">>> \"arch/arm/kernel/early_printk.c\" which does a tx on uart console\n" ">>> and relies on configuration from bootloader.\n" ">>>\n" - ">>> during bootup earlyprink does a tx on uart console and if \302\240uart driver\n" + ">>> during bootup earlyprink does a tx on uart console and if ?uart driver\n" ">>> is not available yet\n" ">>> uart reset or idle done by hwmod layer can cause boot failures.\n" ">>>\n" ">>> --> put_char from earlyprintk.c\n" - ">>> \302\240 \302\240 \302\240--> reset/idle from hwmod layer\n" - ">>> \302\240 \302\240 \302\240 \302\240 \302\240 --> put_char from earlyprintk.c\n" + ">>> ? ? ?--> reset/idle from hwmod layer\n" + ">>> ? ? ? ? ? --> put_char from earlyprintk.c\n" ">>>\n" ">>>\n" ">>> So console_uart reset or clock gating must be done only after uart\n" @@ -131,10 +122,6 @@ "used before it was loaded. This needs to be handled in device init code\n" "as it is today.\n" "\n" - "Kevin\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-omap\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Kevin -951d0cc3ff6b34aae897d6ec76d893d336b39990dab0d9d7978fc8e4a73e40a7 +2dfa84fcab2b6ebf680ce211fbc2cc26c10aba058c6ba3a15536211b42d85164
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.