From: Kevin Hilman <khilman@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PM-WIP/voltdm_c][PATCH 08/11] OMAP4: PM: TWL6030: fix uv to voltage for >0x39
Date: Wed, 18 May 2011 11:41:08 +0200 [thread overview]
Message-ID: <8739kcwdl7.fsf@ti.com> (raw)
In-Reply-To: <1305695854-9638-9-git-send-email-nm@ti.com> (Nishanth Menon's message of "Wed, 18 May 2011 00:17:31 -0500")
Nishanth Menon <nm@ti.com> writes:
> using 1.35V as a check is not correct, we know that beyond 0x39,
> voltages are non linear - hence use the conversion iff uV greater
> than that for 0x39. For example, with 709mV as the smps offset,
> the max linear is actually 1.41V(0x39vsel)!
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Thanks, adding to voltdm queue.
Kevin
> ---
> arch/arm/mach-omap2/omap_twl.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_twl.c b/arch/arm/mach-omap2/omap_twl.c
> index 78fd985..fce7e6d 100644
> --- a/arch/arm/mach-omap2/omap_twl.c
> +++ b/arch/arm/mach-omap2/omap_twl.c
> @@ -134,8 +134,13 @@ static u8 twl6030_uv_to_vsel(unsigned long uv)
> * hardcoding only for 1.35 V which is used for 1GH OPP for
> * OMAP4430.
> */
> - if (uv == 1350000)
> + if (uv > twl6030_vsel_to_uv(0x39)) {
> + if (uv == 1350000)
> + return 0x3A;
> + pr_err("%s:OUT OF RANGE! non mapped vsel for %ld Vs max %ld\n",
> + __func__, uv, twl6030_vsel_to_uv(0x39));
> return 0x3A;
> + }
>
> if (smps_offset & 0x8)
> return DIV_ROUND_UP(uv - 709000, 12660) + 1;
next prev parent reply other threads:[~2011-05-18 9:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 5:17 [PM-WIP/voltdm_c][PATCH 00/11] OMAP4: Fixes for voltage scale Nishanth Menon
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 01/11] OMAP3+: PM: SR: fix debugfs Nishanth Menon
2011-05-18 8:55 ` Kevin Hilman
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 02/11] OMAP3+: PM: voltage: add required debugfs interfaces Nishanth Menon
2011-05-18 7:59 ` Tony Lindgren
2011-05-18 8:06 ` Menon, Nishanth
2011-05-18 8:34 ` Tony Lindgren
2011-05-18 8:41 ` Menon, Nishanth
2011-05-18 8:44 ` Kevin Hilman
2011-05-18 8:50 ` Menon, Nishanth
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 03/11] OMAP3+: PM: VP: fix vstepmax Nishanth Menon
2011-05-18 8:58 ` Kevin Hilman
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 04/11] OMAP4: PM: VC: support configuration of i2c clks Nishanth Menon
2011-05-18 8:53 ` Kevin Hilman
2011-05-18 8:57 ` Menon, Nishanth
2011-05-25 18:17 ` Kevin Hilman
2011-05-25 18:32 ` Menon, Nishanth
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 05/11] OMAP4: PM: VC: fix highspeed i2c for SR Nishanth Menon
2011-05-18 8:59 ` Kevin Hilman
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 06/11] OMAP4: PM: VC: fix channel bit offset for MPU Nishanth Menon
2011-05-18 9:34 ` Kevin Hilman
2011-05-18 9:47 ` Menon, Nishanth
2011-05-18 11:06 ` Kevin Hilman
2011-05-18 11:22 ` Menon, Nishanth
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 07/11] OMAP4: PM: TWL6030: fix voltage conversion formula Nishanth Menon
2011-05-18 9:38 ` Kevin Hilman
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 08/11] OMAP4: PM: TWL6030: fix uv to voltage for >0x39 Nishanth Menon
2011-05-18 9:41 ` Kevin Hilman [this message]
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 09/11] OMAP4: PM: TWL6030: address 0V conversions Nishanth Menon
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 10/11] OMAP4: PM: TWL6030: fix ON/RET/OFF voltages Nishanth Menon
2011-05-18 10:44 ` Kevin Hilman
2011-05-18 5:17 ` [PM-WIP/voltdm_c][PATCH 11/11] OMAP4: PM: TWL6030: add cmd register Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739kcwdl7.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.