From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: OMAP HSMMC problems with off-mode Date: Thu, 09 Dec 2010 15:46:13 -0800 Message-ID: <8739q65x2y.fsf@deeprootsystems.com> References: <4CFE9059.1080202@nokia.com> <87zkseal9c.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:53657 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756444Ab0LIXqS (ORCPT ); Thu, 9 Dec 2010 18:46:18 -0500 Received: by yxt3 with SMTP id 3so1727906yxt.19 for ; Thu, 09 Dec 2010 15:46:17 -0800 (PST) In-Reply-To: (Paul Walmsley's message of "Thu, 9 Dec 2010 11:22:00 -0700 (MST)") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: "Chikkature Rajashekar, Madhusudhan" , Adrian Hunter , =?utf-8?Q?Beno=C3=AEt?= Cousson , Kishore Kadiyala , "linux-omap@vger.kernel.org" , "sawant@ti.com" , "Kristo Tero (Nokia-D/Tampere)" Paul Walmsley writes: > Hi Kevin > > On Thu, 9 Dec 2010, Kevin Hilman wrote: > >> Paul, do you want to submit a formal patch for this for 2.6.38? if not, >> I can add a changelog and queue this with other PM core changes for 2.6.38. > > we should probably come up with a patch for .38 that only increments this > when off-mode is entered... otherwise there will probably be a performance > hit when off-mode-supporting devices are reinitialized after every > clk_enable() :-) The HSMMC driver also resets the IP block when that > happens. I have a series for this (will post shortly), but it only works for omap_devices, since otherwise it's rather hacky to find the powerdomain for a given device. Unfortunately, MMC is still not converted to omap_device/omap_hwmod, so my series doesn't help for MMC. :( Kevin