All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pat Thoyts <patthoyts@users.sourceforge.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	msysgit@googlegroups.com,
	Erik Faye-Lund <kusmabite@googlemail.com>,
	bert Dvornik <dvornik+git@gmail.com>
Subject: Re: Pull request for msysGit patches
Date: Thu, 30 Sep 2010 23:15:10 +0100	[thread overview]
Message-ID: <8739sqj2tt.fsf@fox.patthoyts.tk> (raw)
In-Reply-To: <AANLkTinpSwuhT1_wtqNBeXLCud-F0bLBUgbohdtPp+8R@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 28 Sep 2010 21:23:19 +0000")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

>On Tue, Sep 28, 2010 at 19:10, Junio C Hamano <gitster@pobox.com> wrote:
>
>> git-send-email.perl
>>
>> Similar comment as is_absolute_path(), although in Perl environment I
>> suspect we can just use an existing package without adding our own.
>
>It seems to me that the code added by Erik Faye-Lund in
>33b2e81f84875bf515b4c0de830eeddfd04227dc and this new code in
>"send-email: handle Windows paths for display just like we do for
>processing" by bert could both be replaced by:
>
>    use File::Spec::Functions qw(file_name_is_absolute);
>    file_name_is_absolute($some_path);
>
>And by doing so we'd also be compatible with e.g. VMS. Can the people
>with the odd non-Unix systems maybe try this out and see if it works?
>:)

I just looked into using this function with msysGit. Unfortunately it
doesn't work as our perl is msys-compiled and doesn't recognise c:\ as
an absolute path. It's using the unix path functions.
Possibly we could use a native perl if the git perl functions were
making more use of these platform-abstracting functions. Ultimately this
is the right way to go.

  reply	other threads:[~2010-09-30 22:15 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-28  9:46 Pull request for msysGit patches Pat Thoyts
2010-09-28 19:10 ` Junio C Hamano
2010-09-28 21:11   ` [msysGit] " Johannes Sixt
2010-09-29  3:41     ` Junio C Hamano
2010-09-28 21:23   ` Ævar Arnfjörð Bjarmason
2010-09-30 22:15     ` Pat Thoyts [this message]
2010-09-30 22:52       ` Ævar Arnfjörð Bjarmason
2010-09-30 23:27       ` Erik Faye-Lund
2010-09-29  2:01   ` [msysGit] " Eric Sunshine
     [not found]     ` <7vbp7hrzhb.fsf@alter.siamese.dyndns.org>
2010-09-29  3:54       ` Eric Sunshine
2010-09-29 22:22   ` msysGit patches for upstream Pat Thoyts
2010-09-29 23:02     ` Junio C Hamano
2010-09-29 22:22   ` [PATCH 1/2] Make sure that git_getpass() never returns NULL Pat Thoyts
2010-09-29 22:22   ` [PATCH 2/2] Fix typo in pack-objects' usage Pat Thoyts
2010-09-28 20:52 ` [msysGit] Pull request for msysGit patches Johannes Sixt
2010-09-28 20:58   ` Erik Faye-Lund
2010-09-28 21:13     ` Johannes Sixt
2010-09-28 21:20       ` Erik Faye-Lund
2010-09-28 21:35         ` Erik Faye-Lund
2010-09-28 21:08   ` Jonathan Nieder
2010-09-29 17:51     ` Junio C Hamano
2010-09-29 22:29       ` Pat Thoyts
2010-09-29  2:23   ` Eric Sunshine
2010-09-29  3:37     ` Junio C Hamano
2010-09-29  4:17       ` Eric Sunshine
2010-09-30 13:24   ` [PATCH] git-am: fix detection of absolute paths for windows Pat Thoyts
2010-10-01 17:46     ` Johannes Sixt
2010-09-30 13:24       ` Pat Thoyts
2010-11-07 14:56   ` [PATCH v2 0/4] make open/unlink failures user friendly on windows using retry/abort Heiko Voigt
2010-11-07 14:56     ` [PATCH v2 1/4] mingw: move unlink wrapper to mingw.c Heiko Voigt
2010-11-07 14:56     ` [PATCH v2 2/4] mingw: work around irregular failures of unlink on windows Heiko Voigt
2010-11-07 14:56     ` [PATCH v2 3/4] mingw: make failures to unlink or move raise a question Heiko Voigt
2010-11-07 14:56     ` [PATCH v2 4/4] mingw: add fallback for rmdir in case directory is in use Heiko Voigt
2010-11-07 15:49     ` [PATCH v2 0/4] make open/unlink failures user friendly on windows using retry/abort Johannes Sixt
2010-11-07 17:06       ` Heiko Voigt
2010-11-07 19:11         ` Johannes Sixt
2010-09-29  6:11 ` Pull request for msysGit patches yj2133011
2010-09-29 20:48 ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739sqj2tt.fsf@fox.patthoyts.tk \
    --to=patthoyts@users.sourceforge.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=dvornik+git@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kusmabite@googlemail.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.