All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Relax exit codes for policy-driven lvconvert --repair.
Date: Thu, 07 Jan 2010 21:02:09 +0100	[thread overview]
Message-ID: <873a2h4rb2.fsf@twilight.int.mornfall.net.> (raw)

Hi,

due to the interpretation of "replace" policies as "replace if possible,
downconvert otherwise", we should treat successful downconversion as a
success in these cases, even if we were unable to replace the missing
devices with new ones.

The attached patch also makes the "nothing to repair" condition a
non-error (with and without --use-policies... it's arguably not really
an error). This would hopefully address RHBZ 552723, if it is indeed the
case (as it seems) that the problem there is that the missing devices
have already returned by the time that lvconvert --repair kicks in (and
therefore it does not detect anything to repair).

Yours,
   Petr.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvconvert-relax-failures-with-policy.diff
Type: text/x-diff
Size: 5086 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100107/4728a608/attachment.bin>

             reply	other threads:[~2010-01-07 20:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 20:02 Petr Rockai [this message]
2010-01-07 21:00 ` [PATCH] Relax exit codes for policy-driven lvconvert --repair Petr Rockai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873a2h4rb2.fsf@twilight.int.mornfall.net. \
    --to=prockai@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.