Re: System hang with EXT4

[Dmitry Monakhov <dmonakhov@openvz.org>]

Justin Maggard <jmaggard10@gmail.com> writes:

> On Thu, Dec 10, 2009 at 5:29 PM, Dmitry Monakhov <dmonakhov@openvz.org> wrote:
>> Justin Maggard <jmaggard10@gmail.com> writes:
>>> I have a little more information to add.  After noticing the recent
>>> "Fix potential quota deadlock" patch on the mailing list, I figured it
>>> would be worth a shot to try it without quotas enabled.  This also
>>> avoids the system hang.  I tried applying that patch, but still had
>>> the same symptoms using that kernel.  So I'm seeing a consistent
>>> system hang with ext4 when delalloc and quotas are enabled on an SMP
>>> system.  With either quotas or delalloc disabled, it doesn't hang.
>>> Both enabled on a single processor system also doesn't hang.
>> You also may try another patch
>> "[PATCH] ext4: fix sleep inside spinlock issue aka #14739 V2"
>
> Yes, that patch looks like it did the trick.  Thanks!
Ohhh.. in fact i've to apologies my patch is wrong a little bit
after i_block_reservation_lock was reacquired second time
i_reserved_meta_blocks block's may be changed so we have to
use add instead of assign
 
-       EXT4_I(inode)->i_reserved_meta_blocks = mdblocks;
+       EXT4_I(inode)->i_reserved_meta_blocks += md_needed;
As result quota leak is possible on heavy SMP stress test.
I've already send correct version.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html