From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [PATCH] c/r: Add AF_UNIX support Date: Thu, 04 Jun 2009 14:16:08 -0700 Message-ID: <873aafk8dj.fsf@caffeine.danplanet.com> References: <1244042305-7770-1-git-send-email-danms@us.ibm.com> <20090604201444.GA4302@localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090604201444.GA4302@localdomain> (Louis Rilling's message of "Thu\, 4 Jun 2009 22\:14\:45 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Louis.Rilling-aw0BnHfMbSpBDgjK7y7TUQ@public.gmane.org Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org List-Id: containers.vger.kernel.org LR> GFP_KERNEL is not allowed here, since from->lock is locked. Not LR> sure that GFP_ATOMIC is acceptable though. Perhaps it would be LR> better to temporarily move the queue to a local head, copy it (no LR> spinlock needed), and then push it again. This would need to LR> block concurrent senders/receivers during this operation, unless LR> it's guaranteed that they are all frozen. Ah, yeah, good catch. I'll have to think about that a little. Thanks! -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org